You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/02/14 12:02:29 UTC
Review Request: ignor unassignIPFromVpcNetwork in finally block of
EnableStaticNat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9443/
-----------------------------------------------------------
Review request for cloudstack and Prasanna Santhanam.
Summary (updated)
-----------------
ignor unassignIPFromVpcNetwork in finally block of EnableStaticNat
Description (updated)
-------
This patch only applies on 4.0, not on master(!)
unassignIPFromVpcNetwork processing should not execute when EnableStaticNat succeed.
Without this patch, unassignIPFromVpcNetwork will execute whenever EnableStaticNat is successful or failed.
This is because of the inconsistent of patch of CLOUDSACK-1211 (https://reviews.apache.org/r/9384/ ).
In master, it is ok. https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commitdiff;h=2e2ee2f;hp=8234dfa544625cd300559a7380fee7e9828870f8
In 4.0, it is different. https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commitdiff;h=a61a2b1;hp=19d5f39c579676e59f4b83eb5da3eddef230ff97
Diffs (updated)
-----
server/src/com/cloud/network/rules/RulesManagerImpl.java 6c1e27a
Diff: https://reviews.apache.org/r/9443/diff/
Testing (updated)
-------
Testing OK.
Thanks,
Wei Zhou
Re: Review Request: ignor unassignIPFromVpcNetwork in finally block of
EnableStaticNat
Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9443/#review16575
-----------------------------------------------------------
Ship it!
commit 0ec4217aae5cbfd7702c981fca524b77952b7ccc
Author: Wei Zhou <w....@leaseweb.com>
Date: Thu Feb 14 17:11:05 2013 +0530
ignore unassignIPFromVpcNetwork in finally block of EnableStaticNat
- Prasanna Santhanam
On Feb. 14, 2013, 11:02 a.m., Wei Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9443/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2013, 11:02 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> This patch only applies on 4.0, not on master(!)
>
> unassignIPFromVpcNetwork processing should not execute when EnableStaticNat succeed.
> Without this patch, unassignIPFromVpcNetwork will execute whenever EnableStaticNat is successful or failed.
>
> This is because of the inconsistent of patch of CLOUDSACK-1211 (https://reviews.apache.org/r/9384/ ).
> In master, it is ok. https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commitdiff;h=2e2ee2f;hp=8234dfa544625cd300559a7380fee7e9828870f8
> In 4.0, it is different. https://git-wip-us.apache.org/repos/asf?p=incubator-cloudstack.git;a=commitdiff;h=a61a2b1;hp=19d5f39c579676e59f4b83eb5da3eddef230ff97
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/rules/RulesManagerImpl.java 6c1e27a
>
> Diff: https://reviews.apache.org/r/9443/diff/
>
>
> Testing
> -------
>
> Testing OK.
>
>
> Thanks,
>
> Wei Zhou
>
>