[GitHub] [calcite] julianhyde commented on a diff in pull request #2789: [CALCITE-5126] Implicit column alias for single-column UNNEST should work with any single-column UNNEST’s input

[GitBox <gi...@apache.org>]

julianhyde commented on code in PR #2789:
URL: https://github.com/apache/calcite/pull/2789#discussion_r944642794


##########
core/src/test/resources/sql/unnest.iq:
##########
@@ -105,6 +105,29 @@ from UNNEST(array ['apple', 'banana']) as "fruit";
 
 !ok
 
+select fruit
+from UNNEST(array(select 'banana')) as fruit;
++--------+
+| FRUIT  |
++--------+
+| banana |
++--------+
+(1 row)
+
+!ok
+
+#TODO: Uncomment when CALCITE-5127 will be fixed

Review Comment:
   @dssysolyatin Please remove the comments and use `!if (false) {` instead. (Results in fewer diffs.) Also change 'CALCITE-5127' to '[CALCITE-5127]' for easier search.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org