[GitHub] [inlong] EMsnap commented on a diff in pull request #7289: [INLONG-7292][Sort] Fixed a bug for doris/starrocks/jdbc invokeMultiple method

["EMsnap (via GitHub)" <gi...@apache.org>]

EMsnap commented on code in PR #7289:
URL: https://github.com/apache/inlong/pull/7289#discussion_r1091364011


##########
inlong-sort/sort-connectors/base/src/main/java/org/apache/inlong/sort/base/dirty/DirtySinkHelper.java:
##########
@@ -110,22 +118,56 @@ public void invokeMultiple(T dirtyData, DirtyType dirtyType, Throwable e,
             }
             throw ex;
         }
-        if (dirtySink != null) {
-            JsonNode rootNode;
-            DirtyData.Builder<T> builder = DirtyData.builder();
-            try {
+
+        JsonDynamicSchemaFormat jsonDynamicSchemaFormat =

Review Comment:
   too long for one method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org