You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/01/13 15:24:35 UTC

[GitHub] [incubator-doris] morningman opened a new pull request #2748: [Snapshot] Modify the prefer snapshot version

morningman opened a new pull request #2748: [Snapshot] Modify the prefer snapshot version
URL: https://github.com/apache/incubator-doris/pull/2748
 
 
   In this CL, prefer snapshot version in snapshot request is defined
   in thrift. So that both FE and BE can use this version value.
   
   ISSUE #2432 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version

Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version
URL: https://github.com/apache/incubator-doris/pull/2748#discussion_r366158884
 
 

 ##########
 File path: gensrc/thrift/AgentService.thrift
 ##########
 @@ -178,7 +178,7 @@ struct TSnapshotRequest {
     7: optional bool list_files
     // if all nodes has been upgraded, it can be removed.
     8: optional bool allow_incremental_clone
-    9: optional i32 preferred_snapshot_version = 1  // request preferred snapshot version, default value is 1 for old version be
+    9: optional i32 preferred_snapshot_version = Types.TPREFER_SNAPSHOT_REQ_VERSION
 
 Review comment:
   No problem, the version 1 is no longer used, and if we set it to 1, snapshot will failed.
   Actually, preferred_snapshot_version is a `required` field, and should always be set to
   `TPREFER_SNAPSHOT_REQ_VERSION`. Make it as `optional` is just for compatibility.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] imay merged pull request #2748: [Snapshot] Modify the prefer snapshot version

Posted by GitBox <gi...@apache.org>.
imay merged pull request #2748: [Snapshot] Modify the prefer snapshot version
URL: https://github.com/apache/incubator-doris/pull/2748
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version

Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version
URL: https://github.com/apache/incubator-doris/pull/2748#discussion_r366147077
 
 

 ##########
 File path: gensrc/thrift/AgentService.thrift
 ##########
 @@ -178,7 +178,7 @@ struct TSnapshotRequest {
     7: optional bool list_files
     // if all nodes has been upgraded, it can be removed.
     8: optional bool allow_incremental_clone
-    9: optional i32 preferred_snapshot_version = 1  // request preferred snapshot version, default value is 1 for old version be
+    9: optional i32 preferred_snapshot_version = Types.TPREFER_SNAPSHOT_REQ_VERSION
 
 Review comment:
   You change the default value, is there no compatibility ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] morningman commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version

Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version
URL: https://github.com/apache/incubator-doris/pull/2748#discussion_r366676035
 
 

 ##########
 File path: gensrc/thrift/Types.thrift
 ##########
 @@ -380,3 +380,7 @@ struct TUserIdentity {
     3: optional bool is_domain
 }
 
+const i32 TSNAPSHOT_REQ_VERSION1 = 3;
+const i32 TSNAPSHOT_REQ_VERSION2 = 4;
 
 Review comment:
   OK

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] kangkaisen commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version

Posted by GitBox <gi...@apache.org>.
kangkaisen commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version
URL: https://github.com/apache/incubator-doris/pull/2748#discussion_r366164506
 
 

 ##########
 File path: gensrc/thrift/AgentService.thrift
 ##########
 @@ -178,7 +178,7 @@ struct TSnapshotRequest {
     7: optional bool list_files
     // if all nodes has been upgraded, it can be removed.
     8: optional bool allow_incremental_clone
-    9: optional i32 preferred_snapshot_version = 1  // request preferred snapshot version, default value is 1 for old version be
+    9: optional i32 preferred_snapshot_version = Types.TPREFER_SNAPSHOT_REQ_VERSION
 
 Review comment:
   OK.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org

[GitHub] [incubator-doris] kangpinghuang commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version

Posted by GitBox <gi...@apache.org>.
kangpinghuang commented on a change in pull request #2748: [Snapshot] Modify the prefer snapshot version
URL: https://github.com/apache/incubator-doris/pull/2748#discussion_r366674809
 
 

 ##########
 File path: gensrc/thrift/Types.thrift
 ##########
 @@ -380,3 +380,7 @@ struct TUserIdentity {
     3: optional bool is_domain
 }
 
+const i32 TSNAPSHOT_REQ_VERSION1 = 3;
+const i32 TSNAPSHOT_REQ_VERSION2 = 4;
 
 Review comment:
   add some log to describe the major version function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org