You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by "e-strauss (via GitHub)" <gi...@apache.org> on 2024/09/05 16:33:17 UTC
[PR] Fixed null-pointer exception when LU Decomposition is done on a singular matrix [systemds]
e-strauss opened a new pull request, #2100:
URL: https://github.com/apache/systemds/pull/2100
Fixed null-pointer exception when LU Decomposition is done on a singular matrix
I added a test case for code coverage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed null-pointer exception when LU Decomposition is done on a singular matrix [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard commented on PR #2100:
URL: https://github.com/apache/systemds/pull/2100#issuecomment-2332914459
LGTM and merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed null-pointer exception when LU Decomposition is done on a singular matrix [systemds]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #2100:
URL: https://github.com/apache/systemds/pull/2100#issuecomment-2332709051
## [Codecov](https://app.codecov.io/gh/apache/systemds/pull/2100?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 70.50%. Comparing base [(`7daa590`)](https://app.codecov.io/gh/apache/systemds/commit/7daa5908e5c771c35445dc7f434b75dcccc077ab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4c85cc8`)](https://app.codecov.io/gh/apache/systemds/commit/4c85cc828adef5b1ed6f1145298765aa21eae524?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 5 commits behind head on main.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #2100 +/- ##
=========================================
Coverage 70.50% 70.50%
- Complexity 42071 42072 +1
=========================================
Files 1441 1441
Lines 162297 162299 +2
Branches 31626 31627 +1
=========================================
+ Hits 114425 114437 +12
Misses 38832 38832
+ Partials 9040 9030 -10
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/systemds/pull/2100?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixed null-pointer exception when LU Decomposition is done on a singular matrix [systemds]
Posted by "Baunsgaard (via GitHub)" <gi...@apache.org>.
Baunsgaard closed pull request #2100: Fixed null-pointer exception when LU Decomposition is done on a singular matrix
URL: https://github.com/apache/systemds/pull/2100
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org