[GitHub] [cordova-plugin-splashscreen] 8bhsolutions commented on issue #225: fix(android): Back button fix for SDK28

[GitBox <gi...@apache.org>]

8bhsolutions commented on issue #225: fix(android): Back button fix for SDK28
URL: https://github.com/apache/cordova-plugin-splashscreen/pull/225#issuecomment-532222490
 
 
   @janpio @prageeth 
   I believe the fix is in the right direction, but I don't believe the fix is quite right.
   In an ionic app, the fix incorrectly prevents popping of page.
   
   I've created a sample project that uses prageeths fork.
   [sample project](https://github.com/8bhsolutions/ionic2-socialsharing-with-deeplinking-example)
   
   **Steps**
   1. send text (to anyone) with https://demoapp.com/L/items/2
   2. click the link
   3. App opens into 2 level deep. (Items -> Items Detail)
   4. Use hardware back button
   5. Notice the back button does not pop to root

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org