You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2016/12/31 17:06:26 UTC

svn commit: r1776800 - in /jmeter/trunk/src: components/org/apache/jmeter/timers/ConstantThroughputTimer.java core/org/apache/jmeter/testbeans/gui/TypeEditor.java

Author: pmouawad
Date: Sat Dec 31 17:06:26 2016
New Revision: 1776800

URL: http://svn.apache.org/viewvc?rev=1776800&view=rev
Log:
Sonar : ignore  squid:S00115 "Rename this constant name to match the regular expression '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'"

Modified:
    jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimer.java
    jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TypeEditor.java

Modified: jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimer.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimer.java?rev=1776800&r1=1776799&r2=1776800&view=diff
==============================================================================
--- jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimer.java (original)
+++ jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimer.java Sat Dec 31 17:06:26 2016
@@ -61,11 +61,11 @@ public class ConstantThroughputTimer ext
      * This enum defines the calculation modes used by the ConstantThroughputTimer.
      */
     public enum Mode {
-        ThisThreadOnly("calcMode.1"),
-        AllActiveThreads("calcMode.2"),
-        AllActiveThreadsInCurrentThreadGroup("calcMode.3"),
-        AllActiveThreads_Shared("calcMode.4"),
-        AllActiveThreadsInCurrentThreadGroup_Shared("calcMode.5"),
+        ThisThreadOnly("calcMode.1"), // NOSONAR Keep naming for compatibility
+        AllActiveThreads("calcMode.2"), // NOSONAR Keep naming for compatibility
+        AllActiveThreadsInCurrentThreadGroup("calcMode.3"), // NOSONAR Keep naming for compatibility
+        AllActiveThreads_Shared("calcMode.4"), // NOSONAR Keep naming for compatibility
+        AllActiveThreadsInCurrentThreadGroup_Shared("calcMode.5"), // NOSONAR Keep naming for compatibility
         ;
 
         private final String propertyName; // The property name to be used to look up the display string

Modified: jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TypeEditor.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TypeEditor.java?rev=1776800&r1=1776799&r2=1776800&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TypeEditor.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TypeEditor.java Sat Dec 31 17:06:26 2016
@@ -25,11 +25,11 @@ import java.beans.PropertyEditor;
  * Allow direct specification of property editors.
  */
 public enum TypeEditor {
-    FileEditor     {@Override PropertyEditor getInstance(PropertyDescriptor descriptor) { return new FileEditor(descriptor); }},
-    PasswordEditor {@Override PropertyEditor getInstance(PropertyDescriptor descriptor) { return new PasswordEditor(); }},
-    TableEditor    {@Override PropertyEditor getInstance(PropertyDescriptor descriptor) { return new TableEditor(); }},
-    TextAreaEditor {@Override PropertyEditor getInstance(PropertyDescriptor descriptor) { return new TextAreaEditor(descriptor); }},
-    ComboStringEditor {@Override PropertyEditor getInstance(PropertyDescriptor descriptor) { return new ComboStringEditor(descriptor); }},
+    FileEditor     {@Override PropertyEditor getInstance(PropertyDescriptor descriptor) { return new FileEditor(descriptor); }}, // NOSONAR Keep naming for compatibility
+    PasswordEditor {@Override PropertyEditor getInstance(PropertyDescriptor descriptor) { return new PasswordEditor(); }}, // NOSONAR Keep naming for compatibility
+    TableEditor    {@Override PropertyEditor getInstance(PropertyDescriptor descriptor) { return new TableEditor(); }}, // NOSONAR Keep naming for compatibility
+    TextAreaEditor {@Override PropertyEditor getInstance(PropertyDescriptor descriptor) { return new TextAreaEditor(descriptor); }}, // NOSONAR Keep naming for compatibility
+    ComboStringEditor {@Override PropertyEditor getInstance(PropertyDescriptor descriptor) { return new ComboStringEditor(descriptor); }}, // NOSONAR Keep naming for compatibility
     ;
     // Some editors may need the descriptor
     abstract PropertyEditor getInstance(PropertyDescriptor descriptor);