[GitHub] [incubator-hudi] n3nash commented on a change in pull request #1216: [HUDI-525] lack of insert info in delta_commit inflight

[GitBox <gi...@apache.org>]

n3nash commented on a change in pull request #1216: [HUDI-525] lack of insert info in delta_commit inflight
URL: https://github.com/apache/incubator-hudi/pull/1216#discussion_r368082200
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/HoodieWriteClient.java
 ##########
 @@ -428,6 +428,12 @@ private void saveWorkloadProfileMetadataToInflight(WorkloadProfile profile, Hood
       HoodieCommitMetadata metadata = new HoodieCommitMetadata();
       profile.getPartitionPaths().forEach(path -> {
         WorkloadStat partitionStat = profile.getWorkloadStat(path.toString());
+        HoodieWriteStat insertStat = new HoodieWriteStat();
+        insertStat.setNumInserts(partitionStat.getNumInserts());
+        insertStat.setFileId("");
 
 Review comment:
   Can we just leave them unset ? It should just be null..

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services