You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2017/05/23 20:43:04 UTC
[jira] [Commented] (THRIFT-4206) Strings in container fields are
not decoded properly with py:dynamic and py:utf8strings
[ https://issues.apache.org/jira/browse/THRIFT-4206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16021816#comment-16021816 ]
Jens Geyer commented on THRIFT-4206:
------------------------------------
GitHub user elprans opened a pull request:
https://github.com/apache/thrift/pull/1273
Fix decoding of strings in containers with py:dynamic and py:utf8strings
_read_by_ttype and _write_by_ttype must be using the *element* spec
and not the container spec when determining the correct read/write
handler.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/elprans/thrift py-strings-in-containers
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1273.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1273
----
commit 6edf57c5073e4b452bb1752a9e493c9b779bb24a
Author: Elvis Pranskevichus <el...@pinterest.com>
Date: 2017-05-23T15:36:23Z
Fix decoding of strings in containers with py:dynamic and py:utf8strings
_read_by_ttype and _write_by_ttype must be using the *element* spec
and not the container spec when determining the correct read/write
handler.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
> Strings in container fields are not decoded properly with py:dynamic and py:utf8strings
> ---------------------------------------------------------------------------------------
>
> Key: THRIFT-4206
> URL: https://issues.apache.org/jira/browse/THRIFT-4206
> Project: Thrift
> Issue Type: Bug
> Components: Python - Library
> Affects Versions: 0.10.0
> Reporter: Elvis Pranskevichus
> Fix For: 0.11.0
>
>
> {{_read_by_ttype}} and {{_write_by_ttype}} must be using the *element* spec
> and not the container spec when determining the correct read/write
> handler.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)