You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/09/29 11:02:06 UTC

[GitHub] [pulsar] eolivelli opened a new pull request, #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"

eolivelli opened a new pull request, #17889:
URL: https://github.com/apache/pulsar/pull/17889

   
   This reverts commit 9026d1954d180cfb4b3a38f52217b14a3b5e3dc0.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] lhotari closed pull request #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"

Posted by GitBox <gi...@apache.org>.
lhotari closed pull request #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"
URL: https://github.com/apache/pulsar/pull/17889


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"

Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #17889:
URL: https://github.com/apache/pulsar/pull/17889#issuecomment-1262152981

   @cbornet may add more details.
   A few tests on master branch are now failing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"

Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #17889:
URL: https://github.com/apache/pulsar/pull/17889#issuecomment-1262181050

   > mvn test -pl pulsar-broker -Dtest=NamespaceOwnershipListenerTests
   
   ```
   Message: org.apache.bookkeeper.mledger.ManagedLedgerException$ManagedLedgerFencedException: Can't trim fenced ledger
   
   Stacktrace:
   
   org.apache.pulsar.broker.service.BrokerServiceException$PersistenceException: org.apache.bookkeeper.mledger.ManagedLedgerException$ManagedLedgerFencedException: Can't trim fenced ledger
   	at org.apache.pulsar.broker.service.persistent.PersistentTopic$6.deleteLedgerFailed(PersistentTopic.java:1248)
   	at org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl.lambda$asyncDelete$34(ManagedLedgerImpl.java:2737)
   	at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)
   	at java.base/java.util.concurrent.CompletableFuture.uniWhenCompleteStage(CompletableFuture.java:887)
   	at java.base/java.util.concurrent.CompletableFuture.whenComplete(CompletableFuture.java:2325)
   	at org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl.asyncDelete(ManagedLedgerImpl.java:2734)
   	at org.apache.pulsar.broker.service.persistent.PersistentTopic.lambda$delete$33(PersistentTopic.java:1220)
   	at java.base/java.util.concurrent.CompletableFuture.uniWhenComplete(CompletableFuture.java:863)
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #17889:
URL: https://github.com/apache/pulsar/pull/17889#issuecomment-1262145278

   @eolivelli Please add the following content to your PR description and select a checkbox:
   ```
   - [ ] `doc` <!-- Your PR contains doc changes -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] cbornet commented on pull request #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"

Posted by GitBox <gi...@apache.org>.
cbornet commented on PR #17889:
URL: https://github.com/apache/pulsar/pull/17889#issuecomment-1262163234

   Master fails consistently on several tests:
   [testGetAllPartitions(org.apache.pulsar.broker.namespace.NamespaceOwnershipListenerTests)](https://github.com/cbornet/pulsar/actions/runs/3150096587/jobs/5122627965#step:10:864)
   [producerBacklogQuotaExceededTest(org.apache.pulsar.websocket.proxy.ProxyPublishConsumeTest)](https://github.com/cbornet/pulsar/actions/runs/3150096587/jobs/5122627518#step:10:708)
   
   I have the same failure locally on latest master.
   Can someone else confirm ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao commented on pull request #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"

Posted by GitBox <gi...@apache.org>.
mattisonchao commented on PR #17889:
URL: https://github.com/apache/pulsar/pull/17889#issuecomment-1262125267

   Hi @eolivelli 
   
   Could you tell us why we have to revert it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] eolivelli commented on pull request #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"

Posted by GitBox <gi...@apache.org>.
eolivelli commented on PR #17889:
URL: https://github.com/apache/pulsar/pull/17889#issuecomment-1262183992

   tests are now failing due to https://github.com/apache/pulsar/pull/17736
   
   because "trim" cannot happen if a ManagedLedger is "fenced", and we set "fenced" in "delete".
   so there is some code path in which we "delete" and then try to "trim".
   we should do the opposite...trim and then delete.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] merlimat merged pull request #17889: Revert "[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914)"

Posted by GitBox <gi...@apache.org>.
merlimat merged PR #17889:
URL: https://github.com/apache/pulsar/pull/17889


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org