You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/06 23:40:37 UTC
[GitHub] [hadoop-ozone] fapifta opened a new pull request #777: HDDS-3351.
Remove unnecessary dependency Curator.
fapifta opened a new pull request #777: HDDS-3351. Remove unnecessary dependency Curator.
URL: https://github.com/apache/hadoop-ozone/pull/777
## What changes were proposed in this pull request?
Remove Curator dependency which is not used, and remained there from the time when we migrated the pom.xml to ozone.pom.xml in the Hadoop project.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3351
## How was this patch tested?
Locally I ran 'mvn clean install -DskipTests', it was running fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 merged pull request #777: HDDS-3351.
Remove unnecessary dependency Curator.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 merged pull request #777: HDDS-3351. Remove unnecessary dependency Curator.
URL: https://github.com/apache/hadoop-ozone/pull/777
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] bharatviswa504 commented on issue #777: HDDS-3351.
Remove unnecessary dependency Curator.
Posted by GitBox <gi...@apache.org>.
bharatviswa504 commented on issue #777: HDDS-3351. Remove unnecessary dependency Curator.
URL: https://github.com/apache/hadoop-ozone/pull/777#issuecomment-610120253
Thank You @fapifta for the contribution and @swagle for the review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #777: HDDS-3351. Remove
unnecessary dependency Curator.
Posted by GitBox <gi...@apache.org>.
elek commented on issue #777: HDDS-3351. Remove unnecessary dependency Curator.
URL: https://github.com/apache/hadoop-ozone/pull/777#issuecomment-610295837
Thanks the patch @fapifta (And the quick review @bharatviswa504 and @swagle)
For the record: this patch *doesn't* remove the curator dependency. It modifies a `<dependencyManagement>` not a `<dependency>` section. `<depdendencyManagement>` is reponsible for defining the **default versions** not dependencies.
> Locally I ran 'mvn clean install -DskipTests', it was running fine.
I did the same after this patch (using 9872253e8). And I checked the jar files:
```
mvn clean install -DskipTests
cd hadoop-ozone/dist/target/ozone-0.6.0-SNAPSHOT
find -name "*cura*"
./share/ozone/lib/curator-client-2.12.0.jar
./share/ozone/lib/curator-framework-2.12.0.jar
./share/ozone/lib/curator-recipes-2.12.0.jar
```
Curator is added as a dependency via the transitive dependencies of Hadoop artifacts. To fully remove it you should `<exclude>` it from the dependency hierarchy.
But don't worry. It's a good patch anyway (I am +1, even it if's too late ;-) ).
1. We are not interested in curator, so it can be removed from the `<dependencyManagement>`, too
2. But to remove curator fully we need some exclude rules (the good news is that is should be done by #744, at least on the client side. We should double check the server-side)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org