You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "jwfromm (via GitHub)" <gi...@apache.org> on 2023/03/15 18:04:43 UTC
[GitHub] [tvm] jwfromm opened a new pull request, #14311: [Unity] Enable special dimension value 0 in reshape
jwfromm opened a new pull request, #14311:
URL: https://github.com/apache/tvm/pull/14311
In most definitions of Reshape, having a `0` in the `new_shape` argument means that the shape for that dimension in the output should be copied from the input. This PR extends the shape handling of `relax.op.reshape` to support this case and updates the tests accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #14311: [Unity] Enable special dimension value 0 in reshape
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #14311:
URL: https://github.com/apache/tvm/pull/14311#issuecomment-1470510302
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #14311: [Unity][Op] Enable special dimension value 0 in reshape
Posted by "slyubomirsky (via GitHub)" <gi...@apache.org>.
slyubomirsky commented on PR #14311:
URL: https://github.com/apache/tvm/pull/14311#issuecomment-1470749384
Does the `FInferStructInfo` for reshape reflect the deduced dimensions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] slyubomirsky commented on pull request #14311: [Unity][Op] Enable special dimension value 0 in reshape
Posted by "slyubomirsky (via GitHub)" <gi...@apache.org>.
slyubomirsky commented on PR #14311:
URL: https://github.com/apache/tvm/pull/14311#issuecomment-1470770197
Great. Are there test cases that demonstrate that this is handled correctly during `StructInfo` checking? E.g., just have a binding like `x: R.Tensor((insert resulting shape), "float32") = R.reshape(...)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #14311: [Unity][Op] Enable special dimension value 0 in reshape
Posted by "jwfromm (via GitHub)" <gi...@apache.org>.
jwfromm commented on PR #14311:
URL: https://github.com/apache/tvm/pull/14311#issuecomment-1470767325
Yes, the way it works currently is during the construction of reshape, any special values are rewritten to positive integers. Any down the line passes or inference will see the non-special values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #14311: [Unity][Op] Enable special dimension value 0 in reshape
Posted by "junrushao (via GitHub)" <gi...@apache.org>.
junrushao commented on PR #14311:
URL: https://github.com/apache/tvm/pull/14311#issuecomment-1512424000
Hey I hit this semantics just now in op schema effort :-)
This is definitely an interesting usecase and is not hard to support. I'm just curious in which frameworks 0s are used to indicate copy?
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #14311: [Unity][Op] Enable special dimension value 0 in reshape
Posted by "jwfromm (via GitHub)" <gi...@apache.org>.
jwfromm commented on PR #14311:
URL: https://github.com/apache/tvm/pull/14311#issuecomment-1470800889
The tests in `test_op_manipulate` do exactly that :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm merged pull request #14311: [Unity][Op] Enable special dimension value 0 in reshape
Posted by "jwfromm (via GitHub)" <gi...@apache.org>.
jwfromm merged PR #14311:
URL: https://github.com/apache/tvm/pull/14311
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org