You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Akhil PB <ap...@hortonworks.com> on 2016/01/29 06:12:13 UTC
Re: Review Request 42712: AMBARI-14753: Capsched view: The view does
not show the "effective" permissions of a queue
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42712/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 5:12 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
Repository: ambari
Description
-------
Added effective permissions for acl_submit_application and acl_administer_queue in capshed.
Diffs
-----
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1
Diff: https://reviews.apache.org/r/42712/diff/
Testing (updated)
-------
Done some manual unit testing in both ambari operator and non-operator mode.
Thanks,
Akhil PB
Re: Review Request 42712: AMBARI-14753: Capsched view: The view does
not show the "effective" permissions of a queue
Posted by Sreenath Somarajapuram <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42712/#review119453
-----------------------------------------------------------
Ship it!
Ship It!
- Sreenath Somarajapuram
On Feb. 15, 2016, 1:34 p.m., Akhil PB wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42712/
> -----------------------------------------------------------
>
> (Updated Feb. 15, 2016, 1:34 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
>
>
> Bugs: AMBARI-14753
> https://issues.apache.org/jira/browse/AMBARI-14753
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added effective permissions for acl_submit_application and acl_administer_queue in capshed.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less c0acf4f
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1
>
> Diff: https://reviews.apache.org/r/42712/diff/
>
>
> Testing
> -------
>
> Done some manual unit testing in both ambari operator and non-operator mode.
>
>
> Thanks,
>
> Akhil PB
>
>
Re: Review Request 42712: AMBARI-14753: Capsched view: The view does
not show the "effective" permissions of a queue
Posted by Akhil PB <ap...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42712/
-----------------------------------------------------------
(Updated Feb. 15, 2016, 1:34 p.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
Changes
-------
Patch updated
Bugs: AMBARI-14753
https://issues.apache.org/jira/browse/AMBARI-14753
Repository: ambari
Description
-------
Added effective permissions for acl_submit_application and acl_administer_queue in capshed.
Diffs (updated)
-----
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less c0acf4f
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1
Diff: https://reviews.apache.org/r/42712/diff/
Testing
-------
Done some manual unit testing in both ambari operator and non-operator mode.
Thanks,
Akhil PB
Re: Review Request 42712: AMBARI-14753: Capsched view: The view does
not show the "effective" permissions of a queue
Posted by Akhil PB <ap...@hortonworks.com>.
> On Feb. 13, 2016, 12:56 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js, line 271
> > <https://reviews.apache.org/r/42712/diff/3/?file=1238374#file1238374line271>
> >
> > Typo - 'permissn'
This is not typo, I shortened the variable name. Anyway I will correct it.
> On Feb. 13, 2016, 12:56 a.m., Sreenath Somarajapuram wrote:
> > contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js, line 266
> > <https://reviews.apache.org/r/42712/diff/3/?file=1238374#file1238374line266>
> >
> > Hash/Object would have been a better option for users & groups.
Users and groups arrays are list of users and groups who can administer queue or submit applications respectively.
So why do we need hash here?
It seems simple list would be enough, right?
- Akhil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42712/#review118985
-----------------------------------------------------------
On Feb. 9, 2016, 11:58 a.m., Akhil PB wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42712/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 11:58 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
>
>
> Bugs: AMBARI-14753
> https://issues.apache.org/jira/browse/AMBARI-14753
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added effective permissions for acl_submit_application and acl_administer_queue in capshed.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less c0acf4f
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1
>
> Diff: https://reviews.apache.org/r/42712/diff/
>
>
> Testing
> -------
>
> Done some manual unit testing in both ambari operator and non-operator mode.
>
>
> Thanks,
>
> Akhil PB
>
>
Re: Review Request 42712: AMBARI-14753: Capsched view: The view does
not show the "effective" permissions of a queue
Posted by Sreenath Somarajapuram <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42712/#review118985
-----------------------------------------------------------
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js (line 266)
<https://reviews.apache.org/r/42712/#comment180285>
Hash/Object would have been a better option for users & groups.
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js (line 271)
<https://reviews.apache.org/r/42712/#comment180284>
Typo - 'permissn'
- Sreenath Somarajapuram
On Feb. 9, 2016, 11:58 a.m., Akhil PB wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42712/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2016, 11:58 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
>
>
> Bugs: AMBARI-14753
> https://issues.apache.org/jira/browse/AMBARI-14753
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added effective permissions for acl_submit_application and acl_administer_queue in capshed.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less c0acf4f
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1
>
> Diff: https://reviews.apache.org/r/42712/diff/
>
>
> Testing
> -------
>
> Done some manual unit testing in both ambari operator and non-operator mode.
>
>
> Thanks,
>
> Akhil PB
>
>
Re: Review Request 42712: AMBARI-14753: Capsched view: The view does
not show the "effective" permissions of a queue
Posted by Akhil PB <ap...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42712/
-----------------------------------------------------------
(Updated Feb. 9, 2016, 11:58 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
Changes
-------
Simplifyied logic of finding effective permission.
Bugs: AMBARI-14753
https://issues.apache.org/jira/browse/AMBARI-14753
Repository: ambari
Description
-------
Added effective permissions for acl_submit_application and acl_administer_queue in capshed.
Diffs (updated)
-----
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less c0acf4f
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1
Diff: https://reviews.apache.org/r/42712/diff/
Testing
-------
Done some manual unit testing in both ambari operator and non-operator mode.
Thanks,
Akhil PB
Re: Review Request 42712: AMBARI-14753: Capsched view: The view does
not show the "effective" permissions of a queue
Posted by Sreenath Somarajapuram <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42712/#review118366
-----------------------------------------------------------
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js (line 316)
<https://reviews.apache.org/r/42712/#comment179605>
Can we make this logic simpler. Is there a reason behind converting the array into a different form?
- Sreenath Somarajapuram
On Feb. 8, 2016, 10:20 a.m., Akhil PB wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42712/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 10:20 a.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
>
>
> Bugs: AMBARI-14753
> https://issues.apache.org/jira/browse/AMBARI-14753
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added effective permissions for acl_submit_application and acl_administer_queue in capshed.
>
>
> Diffs
> -----
>
> contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473
> contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less c0acf4f
> contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1
>
> Diff: https://reviews.apache.org/r/42712/diff/
>
>
> Testing
> -------
>
> Done some manual unit testing in both ambari operator and non-operator mode.
>
>
> Thanks,
>
> Akhil PB
>
>
Re: Review Request 42712: AMBARI-14753: Capsched view: The view does
not show the "effective" permissions of a queue
Posted by Akhil PB <ap...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42712/
-----------------------------------------------------------
(Updated Feb. 8, 2016, 10:20 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
Bugs: AMBARI-14753
https://issues.apache.org/jira/browse/AMBARI-14753
Repository: ambari
Description
-------
Added effective permissions for acl_submit_application and acl_administer_queue in capshed.
Diffs (updated)
-----
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473
contrib/views/capacity-scheduler/src/main/resources/ui/app/styles/application.less c0acf4f
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1
Diff: https://reviews.apache.org/r/42712/diff/
Testing
-------
Done some manual unit testing in both ambari operator and non-operator mode.
Thanks,
Akhil PB
Re: Review Request 42712: AMBARI-14753: Capsched view: The view does
not show the "effective" permissions of a queue
Posted by Akhil PB <ap...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42712/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 5:13 a.m.)
Review request for Ambari, DIPAYAN BHOWMICK, Pallav Kulshreshtha, and Sreenath Somarajapuram.
Bugs: AMBARI-14753
https://issues.apache.org/jira/browse/AMBARI-14753
Repository: ambari
Description
-------
Added effective permissions for acl_submit_application and acl_administer_queue in capshed.
Diffs
-----
contrib/views/capacity-scheduler/src/main/resources/ui/app/controllers/queue.js 521b473
contrib/views/capacity-scheduler/src/main/resources/ui/app/templates/queue.hbs 15550d1
Diff: https://reviews.apache.org/r/42712/diff/
Testing
-------
Done some manual unit testing in both ambari operator and non-operator mode.
Thanks,
Akhil PB