You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2020/12/15 00:05:07 UTC
[GitHub] [plc4x] splatch opened a new pull request #211: CANopen over socketcan transport
splatch opened a new pull request #211:
URL: https://github.com/apache/plc4x/pull/211
This is work in progress to finally merge canopen driver to develop branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] splatch merged pull request #211: [WIP] CANopen over socketcan transport
Posted by GitBox <gi...@apache.org>.
splatch merged pull request #211:
URL: https://github.com/apache/plc4x/pull/211
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] splatch commented on pull request #211: CANopen over socketcan transport
Posted by GitBox <gi...@apache.org>.
splatch commented on pull request #211:
URL: https://github.com/apache/plc4x/pull/211#issuecomment-745469826
I've added necessary documentation and links. Awaiting Jenkins to complete his job :pray:.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] splatch commented on pull request #211: [WIP] CANopen over socketcan transport
Posted by GitBox <gi...@apache.org>.
splatch commented on pull request #211:
URL: https://github.com/apache/plc4x/pull/211#issuecomment-745178213
> data-io-template doesn't break anything
It seems not, all the tests are working fine and it is aimed to help with plain arrays. A lot of canopen stuff is mapped to `byte[8]` and I found that existing data-io was not able to map this answers properly. I had to expand freemarker macro to multiple lines to understand it. I can fold it back to single line.
And yes, I want canopen to leave sandbox after spending there past 4 months! I will do relocations and add improve a little bit documentation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org