You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by "penggeyuanlishe (via GitHub)" <gi...@apache.org> on 2023/06/22 10:27:27 UTC

[GitHub] [dolphinscheduler] penggeyuanlishe commented on issue #14397: [Bug] [api] After the workflow is exported and imported again, no newly imported task definition appears on the workflow definition page

penggeyuanlishe commented on issue #14397:
URL: https://github.com/apache/dolphinscheduler/issues/14397#issuecomment-1602397597

   https://github.com/apache/dolphinscheduler/pull/14398
   上述方案思路如下：
   查看任务定义页面的接口：
   ![image-20230622175406766](https://github.com/apache/dolphinscheduler/assets/109343165/ba3a41ad-d379-4c2b-93cc-d3c258d3d9e2)
   
   找到对应源码，发现该接口的 taskExecuteType 有默认值，为 "BATCH"：
   ![image-20230622180920272](https://github.com/apache/dolphinscheduler/assets/109343165/8f65f3a3-17c2-4e16-8c4c-37d447541ae9)
   
   继续跟踪源码，找到对应的SQL语句：
   ![image-20230622181035358](https://github.com/apache/dolphinscheduler/assets/109343165/5da06da5-3ff2-4dae-a21c-67e86f4f2d55)
   
   由于 taskExecuteType 有默认值"BATCH"，不会为空，所以`and td.task_execute_type = #{taskExecuteType.code}`该代码将会执行。到数据库一看，刚才导入的工作流对应的 task_execute_type 果然为空：
   ![image-20230622181336899](https://github.com/apache/dolphinscheduler/assets/109343165/144d0c46-18c6-4e46-a78c-a7163e8982f1)
   
   排查原因，发现在 org.apache.dolphinscheduler.api.service.impl.ProcessDefinitionServiceImpl#checkAndImport 方法中，
   org.apache.dolphinscheduler.dao.entity.TaskDefinitionLog 类的构造方法，未将该值赋值进去，所以导致 TaskDefinitionLog 对象中的 taskExecuteType 并未赋值，因此存入数据库中即为 null 。
   ![image-20230622181647773](https://github.com/apache/dolphinscheduler/assets/109343165/031b1041-3522-4559-987e-58e151e0ec8a)
   
   于是，解决方案便是修改该构造方法：
   ![image-20230622181943695](https://github.com/apache/dolphinscheduler/assets/109343165/6a316c00-c596-4bee-8d9c-21ef96cbd14d)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org