You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "Joe McDonnell (Jira)" <ji...@apache.org> on 2023/04/20 16:10:00 UTC
[jira] [Commented] (IMPALA-12069) Remove BUILD_HISTORICAL mode from native-toolchain
[ https://issues.apache.org/jira/browse/IMPALA-12069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17714664#comment-17714664 ]
Joe McDonnell commented on IMPALA-12069:
----------------------------------------
Toolchain change: [https://github.com/cloudera/native-toolchain/commit/de3c340f9da6d277bc2dfd032d593c2631a5e3c7]
{noformat}
commit de3c340f9da6d277bc2dfd032d593c2631a5e3c7
Author: Joe McDonnell <jo...@cloudera.com>
Date: Fri Apr 14 19:20:37 2023 -0700
IMPALA-12069: Remove BUILD_HISTORICAL option
The BUILD_HISTORICAL option hasn't worked in a long time, and it
clutters the codebase with build code and patches for old
versions. This change removes the BUILD_HISTORICAL option and
all patches for old versions of components.
It also retires some old build logic for old versions. For
example, older versions of Snappy used autotools, but Snappy
switched to CMake. This cleans up the build script, removing
the old autotools logic. This applies to other components as
well.
This removes a couple locations of out of date OS-X darwin logic,
where darwin is referencing an old version of a component that
is clearly useless to modern Impala.
Testing:
- Ran a toolchain build
Change-Id: Ib2df0af087af14f57e80b5ed94879bd1434501d4
Reviewed-on: http://gerrit.cloudera.org:8080/19755
Reviewed-by: Michael Smith <mi...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Joe McDonnell <jo...@cloudera.com>
{noformat}
> Remove BUILD_HISTORICAL mode from native-toolchain
> --------------------------------------------------
>
> Key: IMPALA-12069
> URL: https://issues.apache.org/jira/browse/IMPALA-12069
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.3.0
> Reporter: Joe McDonnell
> Priority: Major
>
> The native-toolchain keeps build code for all of the old versions of packages in the repository under a BUILD_HISTORICAL option. BUILD_HISTORICAL can't possibly function, because most old versions are not buildable with GCC 10 (or even GCC 7). To my knowledge, no one has used it for any reason in the past several years.
> It complicates the repository, because build scripts must handle old versions alongside new versions. Patches for old versions of components never get deleted. This makes no sense, because all of the logic is available in the git history.
> This tracks removing BUILD_HISTORICAL and cleaning up the repository to remove old build scripts, old patches, etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org