You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/14 02:44:49 UTC

[GitHub] [rocketmq-connect] Slideee opened a new issue, #90: WorkerDirectTask put position may partially store information lost

Slideee opened a new issue, #90:
URL: https://github.com/apache/rocketmq-connect/issues/90

   The issue tracker is used for bug reporting purposes **ONLY** whereas feature request needs to follow the [RIP process](https://github.com/apache/rocketmq/wiki/RocketMQ-Improvement-Proposal). To avoid unnecessary duplication, please check whether there is a previous issue before filing a new one.
   
   It is recommended to start a discussion thread in the [mailing lists](http://rocketmq.apache.org/about/contact/) in cases of discussing your deployment plan, API clarification, and other non-bug-reporting issues.
   We welcome any friendly suggestions, bug fixes, collaboration, and other improvements.
   
   Please ensure that your bug report is clear and self-contained. Otherwise, it would take additional rounds of communication, thus more time, to understand the problem itself.
   
   Generally, fixing an issue goes through the following steps:
   1. Understand the issue reported;
   1. Reproduce the unexpected behavior locally;
   1. Perform root cause analysis to identify the underlying problem;
   1. Create test cases to cover the identified problem;
   1. Work out a solution to rectify the behavior and make the newly created test cases pass;
   1. Make a pull request and go through peer review;
   
   As a result, it would be very helpful yet challenging if you could provide an isolated project reproducing your reported issue. Anyway, please ensure your issue report is informative enough for the community to pick up. At a minimum, include the following hints:
   
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   
   - What did you do (The steps to reproduce)?
   
   - What is expected to see?
   
   - What did you see instead?
   
   2. Please tell us about your environment:
   
   3. Other information (e.g. detailed explanation, logs, related issues, suggestions on how to fix, etc):
   
   **FEATURE REQUEST**
   
   1. Please describe the feature you are requesting.
   
   2. Provide any additional detail on your proposed use case for this feature.
   
   2. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?
   
   4. If there are some sub-tasks involved, use -[] for each sub-task and create a corresponding issue to map to the sub-task:
   
   - [sub-task1-issue-number](example_sub_issue1_link_here): sub-task1 description here, 
   - [sub-task2-issue-number](example_sub_issue2_link_here): sub-task2 description here,
   - ...
   - 
   For the method of sendRecord in WorkerDirectTask, there may be multiple sets of RecordPartition and RecordOffset in sourceDataEntries, so these two variables should be inside the loop body and can be stored by Map. At present, writing this way will cause these two variables to be overwritten all the time, resulting in partial The storage of the offset is abnormal
   ![image](https://user-images.githubusercontent.com/48793283/163302628-79c5ac01-0b78-4159-bf39-ae733e447dac.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-connect] odbozhou commented on issue #90: WorkerDirectTask put position may partially store information lost

Posted by GitBox <gi...@apache.org>.
odbozhou commented on issue #90:
URL: https://github.com/apache/rocketmq-connect/issues/90#issuecomment-1108109340

   > @odbozhou can you take a look at this question? In addition, is there any plan to adapt the new api of replicator? If no one does, I will do it.
   
   I saw the pr that your replicator adapts to the latest connect api, it's great


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-connect] odbozhou closed issue #90: WorkerDirectTask put position may partially store information lost

Posted by GitBox <gi...@apache.org>.
odbozhou closed issue #90: WorkerDirectTask put position may partially store information lost
URL: https://github.com/apache/rocketmq-connect/issues/90


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-connect] Slideee commented on issue #90: WorkerDirectTask put position may partially store information lost

Posted by GitBox <gi...@apache.org>.
Slideee commented on issue #90:
URL: https://github.com/apache/rocketmq-connect/issues/90#issuecomment-1106079702

   @odbozhou can you take a look at this question? In addition, is there any plan to adapt the new api of replicator? If no one does, I will do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [rocketmq-connect] odbozhou commented on issue #90: WorkerDirectTask put position may partially store information lost

Posted by GitBox <gi...@apache.org>.
odbozhou commented on issue #90:
URL: https://github.com/apache/rocketmq-connect/issues/90#issuecomment-1110597433

   merged


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org