You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/06/05 03:53:05 UTC
[GitHub] [flink] gaoyunhaii opened a new pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
gaoyunhaii opened a new pull request #12496:
URL: https://github.com/apache/flink/pull/12496
## What is the purpose of the change
This PR fixed the issue that the `BucketLifeCycleListener` in `StreamingFileSink` misses the notification for buckets detected inactive on restoring. On restoring, the buckets with only pending files will get all the pending files committed and will not be recorded. At this time, `StreamingFileSink` should notify that the buckets get inactive.
## Brief change log
- 18db5ae4db2c5284bf0530c60e05f02be3a40d19 adds the missed notification.
## Verifying this change
This change added tests and can be verified as follows:
- Added test that validates that the notification is sent on restoring if buckets get inactive.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): **no**
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
- The serializers: **no**
- The runtime per-record code paths (performance sensitive): **no**
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: **no**
- The S3 file system connector: **no**
## Documentation
- Does this pull request introduce a new feature? **no**
- If yes, how is the feature documented? **not applicable**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12496:
URL: https://github.com/apache/flink/pull/12496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12496:
URL: https://github.com/apache/flink/pull/12496#issuecomment-639245821
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2776",
"triggerID" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"triggerType" : "PUSH"
}, {
"hash" : "ecd96fe843f4aa45178e54bcdb2cb1e3f8ff831b",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2871",
"triggerID" : "ecd96fe843f4aa45178e54bcdb2cb1e3f8ff831b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ecd96fe843f4aa45178e54bcdb2cb1e3f8ff831b Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2871)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12496:
URL: https://github.com/apache/flink/pull/12496#issuecomment-639245821
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2776",
"triggerID" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18db5ae4db2c5284bf0530c60e05f02be3a40d19 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2776)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12496:
URL: https://github.com/apache/flink/pull/12496#issuecomment-639245821
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2776",
"triggerID" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"triggerType" : "PUSH"
}, {
"hash" : "ecd96fe843f4aa45178e54bcdb2cb1e3f8ff831b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ecd96fe843f4aa45178e54bcdb2cb1e3f8ff831b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18db5ae4db2c5284bf0530c60e05f02be3a40d19 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2776)
* ecd96fe843f4aa45178e54bcdb2cb1e3f8ff831b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12496:
URL: https://github.com/apache/flink/pull/12496#issuecomment-639245821
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2776",
"triggerID" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18db5ae4db2c5284bf0530c60e05f02be3a40d19 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2776)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12496:
URL: https://github.com/apache/flink/pull/12496#issuecomment-639245821
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2776",
"triggerID" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"triggerType" : "PUSH"
}, {
"hash" : "ecd96fe843f4aa45178e54bcdb2cb1e3f8ff831b",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2871",
"triggerID" : "ecd96fe843f4aa45178e54bcdb2cb1e3f8ff831b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18db5ae4db2c5284bf0530c60e05f02be3a40d19 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2776)
* ecd96fe843f4aa45178e54bcdb2cb1e3f8ff831b Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=2871)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi merged pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
JingsongLi merged pull request #12496:
URL: https://github.com/apache/flink/pull/12496
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on a change in pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on a change in pull request #12496:
URL: https://github.com/apache/flink/pull/12496#discussion_r436341479
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
##########
@@ -187,6 +187,10 @@ private void handleRestoredBucketState(final BucketState<BucketID> recoveredStat
private void updateActiveBucketId(final BucketID bucketId, final Bucket<IN, BucketID> restoredBucket) throws IOException {
if (!restoredBucket.isActive()) {
+ if (bucketLifeCycleListener != null) {
Review comment:
Extracted the common `notifyBucketCreate` and `notifyBucketInactive` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12496:
URL: https://github.com/apache/flink/pull/12496#issuecomment-639245821
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "18db5ae4db2c5284bf0530c60e05f02be3a40d19",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18db5ae4db2c5284bf0530c60e05f02be3a40d19 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] JingsongLi commented on a change in pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
JingsongLi commented on a change in pull request #12496:
URL: https://github.com/apache/flink/pull/12496#discussion_r435772952
##########
File path: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/sink/filesystem/Buckets.java
##########
@@ -187,6 +187,10 @@ private void handleRestoredBucketState(final BucketState<BucketID> recoveredStat
private void updateActiveBucketId(final BucketID bucketId, final Bucket<IN, BucketID> restoredBucket) throws IOException {
if (!restoredBucket.isActive()) {
+ if (bucketLifeCycleListener != null) {
Review comment:
Add a method: `inactiveBucket(Bucket<IN, BucketID>)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] gaoyunhaii commented on pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
gaoyunhaii commented on pull request #12496:
URL: https://github.com/apache/flink/pull/12496#issuecomment-640180940
Very thanks @JingsongLi for the reviewing! I have update the PR according to the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12496:
URL: https://github.com/apache/flink/pull/12496#issuecomment-639245821
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #12496: [FLINK-18110][fs-connector] StreamingFileSink notifies for buckets detected to be inactive on restoring
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12496:
URL: https://github.com/apache/flink/pull/12496#issuecomment-639243709
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 18db5ae4db2c5284bf0530c60e05f02be3a40d19 (Fri Jun 05 03:56:10 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org