[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1282: MINIFICPP-1773 - Crash when using Provenance Repository in properties

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1282:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1282#discussion_r823603532



##########
File path: extensions/rocksdb-repos/ProvenanceRepository.h
##########
@@ -72,7 +72,7 @@ class ProvenanceRepository : public core::Repository, public std::enable_shared_
     if (running_)
       return;
     running_ = true;
-    thread_ = std::thread(&ProvenanceRepository::run, shared_from_this());
+    thread_ = std::thread(&ProvenanceRepository::run, this);

Review comment:
       I think the mac failure comes from the main branch. Something caused that test to fail about half the time on mac.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org