You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (JIRA)" <ji...@apache.org> on 2010/08/11 12:35:19 UTC

[jira] Created: (LUCENE-2596) IndexWriter.setInfoStream no longer prints certain config (mergeFactor, useCompoundFile)

IndexWriter.setInfoStream no longer prints certain config (mergeFactor, useCompoundFile)
----------------------------------------------------------------------------------------

                 Key: LUCENE-2596
                 URL: https://issues.apache.org/jira/browse/LUCENE-2596
             Project: Lucene - Java
          Issue Type: Bug
          Components: Index
    Affects Versions: 3.1, 4.0
            Reporter: Michael McCandless
            Priority: Minor


These can be important to see for debugging.

We lost them in the cutover to IWC.

Just opening this issue to remind us to get them back, before releasing...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2596) IndexWriter.setInfoStream no longer prints certain config (mergeFactor, useCompoundFile)

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897212#action_12897212 ] 

Shai Erera commented on LUCENE-2596:
------------------------------------

This line

{code}
            "mergePolicy=" + mergePolicy + "\n" + 
{code}

is redundant as it's printed from config.toString(). So if you intend to fix anything here, this line should be removed.

> IndexWriter.setInfoStream no longer prints certain config (mergeFactor, useCompoundFile)
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2596
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2596
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 3.1, 4.0
>            Reporter: Michael McCandless
>            Priority: Minor
>
> These can be important to see for debugging.
> We lost them in the cutover to IWC.
> Just opening this issue to remind us to get them back, before releasing...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Resolved: (LUCENE-2596) Impl toString() in MergePolicy and its extensions

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera resolved LUCENE-2596.
--------------------------------

    Resolution: Fixed

Committed revision 988512 (3x).
Committed revision 988517 (trunk).

> Impl toString() in MergePolicy and its extensions
> -------------------------------------------------
>
>                 Key: LUCENE-2596
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2596
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 3.1, 4.0
>            Reporter: Michael McCandless
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2596.patch
>
>
> These can be important to see for debugging.
> We lost them in the cutover to IWC.
> Just opening this issue to remind us to get them back, before releasing...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2596) Impl toString() in MergePolicy and its extensions

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-2596:
-------------------------------

          Summary: Impl toString() in MergePolicy and its extensions  (was: IndexWriter.setInfoStream no longer prints certain config (mergeFactor, useCompoundFile))
       Issue Type: Improvement  (was: Bug)
         Assignee: Shai Erera
    Fix Version/s: 3.1
                   4.0
    Lucene Fields: [New, Patch Available]  (was: [New])

Renaming subject to a more accurate one. Will post a patch soon.

> Impl toString() in MergePolicy and its extensions
> -------------------------------------------------
>
>                 Key: LUCENE-2596
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2596
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 3.1, 4.0
>            Reporter: Michael McCandless
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>
> These can be important to see for debugging.
> We lost them in the cutover to IWC.
> Just opening this issue to remind us to get them back, before releasing...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2596) IndexWriter.setInfoStream no longer prints certain config (mergeFactor, useCompoundFile)

Posted by "Michael McCandless (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897237#action_12897237 ] 

Michael McCandless commented on LUCENE-2596:
--------------------------------------------

Hmm it looks like IW has never included useCFS/mergeFactor in its infoStream output... (weird! I thought they did).

So this is not in fact a regression!

But still let's fix the MPs to have an "interesting" toString that includes their settings (not just useCFS/mergeFactor but other interesting ones like maxMergeDocs/MB, minMergeDocs/MB too).

> IndexWriter.setInfoStream no longer prints certain config (mergeFactor, useCompoundFile)
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2596
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2596
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 3.1, 4.0
>            Reporter: Michael McCandless
>            Priority: Minor
>
> These can be important to see for debugging.
> We lost them in the cutover to IWC.
> Just opening this issue to remind us to get them back, before releasing...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Commented: (LUCENE-2596) IndexWriter.setInfoStream no longer prints certain config (mergeFactor, useCompoundFile)

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/LUCENE-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12897210#action_12897210 ] 

Shai Erera commented on LUCENE-2596:
------------------------------------

Mike, messageState() looks like this:
{code}
  private void messageState() {
    message("\ndir=" + directory + "\n" +
            "mergePolicy=" + mergePolicy + "\n" + 
            "index=" + segString() + "\n" +
            "version=" + Constants.LUCENE_VERSION + "\n" +
            config.toString());
  }
{code}

There is a config.toString() printout which includes all of IWC info. Is something else missing?

> IndexWriter.setInfoStream no longer prints certain config (mergeFactor, useCompoundFile)
> ----------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2596
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2596
>             Project: Lucene - Java
>          Issue Type: Bug
>          Components: Index
>    Affects Versions: 3.1, 4.0
>            Reporter: Michael McCandless
>            Priority: Minor
>
> These can be important to see for debugging.
> We lost them in the cutover to IWC.
> Just opening this issue to remind us to get them back, before releasing...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


[jira] Updated: (LUCENE-2596) Impl toString() in MergePolicy and its extensions

Posted by "Shai Erera (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/LUCENE-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Shai Erera updated LUCENE-2596:
-------------------------------

    Attachment: LUCENE-2596.patch

Adds the toString() impls

> Impl toString() in MergePolicy and its extensions
> -------------------------------------------------
>
>                 Key: LUCENE-2596
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2596
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: Index
>    Affects Versions: 3.1, 4.0
>            Reporter: Michael McCandless
>            Assignee: Shai Erera
>            Priority: Minor
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2596.patch
>
>
> These can be important to see for debugging.
> We lost them in the cutover to IWC.
> Just opening this issue to remind us to get them back, before releasing...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org