You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Bryan Duxbury (JIRA)" <ji...@apache.org> on 2009/05/05 00:00:31 UTC
[jira] Created: (THRIFT-481) indentation of ruby classes is off by
a few
indentation of ruby classes is off by a few
-------------------------------------------
Key: THRIFT-481
URL: https://issues.apache.org/jira/browse/THRIFT-481
Project: Thrift
Issue Type: Bug
Components: Compiler (Ruby)
Affects Versions: 0.1
Reporter: Bryan Duxbury
Priority: Trivial
For some reason it looks like the generator indents more than it outdents in some strange way, leading to the end of the file being indented several columns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-481) indentation of ruby classes is off
by a few
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705834#action_12705834 ]
Kevin Clark commented on THRIFT-481:
------------------------------------
That's not the case. The generator does it bits at a time. See void t_rb_generator::init_generator().
> indentation of ruby classes is off by a few
> -------------------------------------------
>
> Key: THRIFT-481
> URL: https://issues.apache.org/jira/browse/THRIFT-481
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Affects Versions: 0.1
> Reporter: Bryan Duxbury
> Priority: Trivial
>
> For some reason it looks like the generator indents more than it outdents in some strange way, leading to the end of the file being indented several columns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-481) indentation of ruby classes is off
by a few
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705831#action_12705831 ]
Bryan Duxbury commented on THRIFT-481:
--------------------------------------
Can you clarify what you mean by multiple files are being generated concurrently? I would have thought that we'd generate all of the types file, then all of the constants file, then all of the services, etc. Is this not the case?
> indentation of ruby classes is off by a few
> -------------------------------------------
>
> Key: THRIFT-481
> URL: https://issues.apache.org/jira/browse/THRIFT-481
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Affects Versions: 0.1
> Reporter: Bryan Duxbury
> Priority: Trivial
>
> For some reason it looks like the generator indents more than it outdents in some strange way, leading to the end of the file being indented several columns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-481) indentation of ruby classes is off
by a few
Posted by "Kevin Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705781#action_12705781 ]
Kevin Clark commented on THRIFT-481:
------------------------------------
So, it *used* to do this because the indentation variable is global, and multiple files are generated concurrently. Mark and I had decided it wasn't a big enough deal to fix.
> indentation of ruby classes is off by a few
> -------------------------------------------
>
> Key: THRIFT-481
> URL: https://issues.apache.org/jira/browse/THRIFT-481
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Affects Versions: 0.1
> Reporter: Bryan Duxbury
> Priority: Trivial
>
> For some reason it looks like the generator indents more than it outdents in some strange way, leading to the end of the file being indented several columns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-481) indentation of ruby classes is off
by a few
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705841#action_12705841 ]
Bryan Duxbury commented on THRIFT-481:
--------------------------------------
Hm. Maybe I will have an intern refactor the code generation stuff like this over the summer :)
> indentation of ruby classes is off by a few
> -------------------------------------------
>
> Key: THRIFT-481
> URL: https://issues.apache.org/jira/browse/THRIFT-481
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Ruby)
> Affects Versions: 0.1
> Reporter: Bryan Duxbury
> Priority: Trivial
>
> For some reason it looks like the generator indents more than it outdents in some strange way, leading to the end of the file being indented several columns
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.