[GitHub] [superset] jfrag1 edited a comment on pull request #16618: [WiP] feat: feature flag configurable custom backend

[GitBox <gi...@apache.org>]

jfrag1 edited a comment on pull request #16618:
URL: https://github.com/apache/superset/pull/16618#issuecomment-914497766


   I think this feature flag backend would also need to be able to evaluate all feature flags to send via bootstrap [here](https://github.com/apache/superset/blob/master/superset/views/base.py#L367). Otherwise, you'd still need to define a `GET_FEATURE_FLAGS_FUNC` to get the proper values to the frontend, which seems like it would defeat the purpose of having a custom backend.
   
   Update:
   Disregard, I see now that this can be achieved with the `COMMON_BOOTSTRAP_OVERRIDES_FUNC` config. It may be good to make a note that it is required to do this to ensure flags are consistent between bootstrap and the custom backend


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org