You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2022/06/03 03:21:13 UTC
[GitHub] [myfaces] volosied opened a new pull request, #268: 2.2.x javadoc cleanup
volosied opened a new pull request, #268:
URL: https://github.com/apache/myfaces/pull/268
I encountered a lot of javadoc errors during my attempt at the 2.2.15 release, and I'm not sure why? I wonder if they were seen in the last release? Nevertheless, I cherry-picked numerous commits to update the javadocs and have them be consistent with the other branches.
`-Xdoclint:none` likely fixed the errors in the javadoc release however.
I can squash it all before merging, however.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on a diff in pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
melloware commented on code in PR #268:
URL: https://github.com/apache/myfaces/pull/268#discussion_r888850793
##########
impl/pom.xml:
##########
@@ -953,8 +953,8 @@
</activation>
<build>
<plugins>
-
<plugin>
+ <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<excludePackageNames>org.apache.myfaces.ee6</excludePackageNames>
Review Comment:
I think its redundant but OK I think all plugins if not listed default to `org.apache.maven.plugins`. I also had an issue building wiht Maven 3.8.5 this branch because it has a Tomcat Repo in the pom.xml that uses HTTP instead of HTTPS. I removed that repo and the build worked for me. Not sure if you have run into that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1149108047
`mvn clean install` followed by `mvn install -Pgenerate-assembly -Papache-release -Dgpg.passphrase=yourphrase` got me a BUILD SUCCESS.
java -version
> openjdk version "1.8.0_312"
> OpenJDK Runtime Environment (build 1.8.0_312-8u312-b07-0ubuntu1~20.04-b07)
> OpenJDK 64-Bit Server VM (build 25.312-b07, mixed mode)
So likely this is just a JavaDoc difference between JDKs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1146384066
Thanks. I'm gonna wait for Paul to respond before merging anything (he did the last 2.2 release). This just might be JDK issue.
We'll try to get this release out next week, though. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1149409055
No idea what I'm doing wrong. I keep getting javadoc errors. I can't find 1.8.0_312 specifically, but the two JDKs below both gave me the same javadoc errors.... :/ I'm also using Mac OS, but I didn't have any trouble with the other releases.
```
openjdk version "1.8.0_292"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed mode)
```
[ERROR] Exit code: 1 - ~/open-source/myfaces/api/src/main/java/javax/faces/context/ExternalContext.java:43: warning: no description for @param
[ERROR] * @param name
[ERROR] ^
....
```
openjdk version "1.8.0_322"
OpenJDK Runtime Environment (build 1.8.0_322-bre_2022_02_28_15_01-b00)
OpenJDK 64-Bit Server VM (build 25.322-b00, mixed mode)
```
myfaces-api: MavenReportException: Error while creating archive:
[ERROR] Exit code: 1 - ~/open-source/myfaces/api/src/main/java/javax/faces/context/ExternalContext.java:43: warning: no description for @param
[ERROR] * @param name
....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied closed pull request #268: 2.2.x javadoc cleanup -- Xdoclint:none
Posted by GitBox <gi...@apache.org>.
volosied closed pull request #268: 2.2.x javadoc cleanup -- Xdoclint:none
URL: https://github.com/apache/myfaces/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1149961541
When I run with...
```
Apache Maven 3.8.5 (3599d3414f046de2324203b78ddcf9b5e4388aa0)
Maven home: C:\Tools\apache-maven-3.8.5
Java version: 11.0.10, vendor: AdoptOpenJDK, runtime: C:\Tools\jdk-11.0.10
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
```
I get this error...
```
[ERROR] Failed to execute goal on project myfaces-impl: Could not resolve dependencies for project org.apache.myfaces.core:myfaces-impl:jar:2.2.15-SNAPSHOT: Could not transfer artifact org.apache.myfaces.core:myfaces-api:jar:tests:2.2.15-SNAPSHOT from/to maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories: [tomcat (http://tomcat.apache.org/dev/dist/m2-repository, default, releases+snapshots)] -
```
It is due to this in Maven 3.8.1 and higher..
> Maven now disables all insecure http://* mirrors by default. Here is explanation from maven mainteners: http://maven.apache.org/docs/3.8.1/release-notes.html#cve-2021-26291
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1149157544
I would not do such cosmetics in this old Branch if not really required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1149197944
@pnicolucci that is good news but I am curious what version of Apache Maven you used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1149248294
> @pnicolucci that is good news but I am curious what version of Apache Maven you used?
`Apache Maven 3.6.3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on pull request #268: 2.2.x javadoc cleanup -- Xdoclint:none
Posted by GitBox <gi...@apache.org>.
volosied commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1151220657
Thanks, Thomas! Build is working for me now, so I'll close this PR and finish up the 2.2 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1148961468
I'll try to run the release commands locally and see if I hit the same issue or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] pnicolucci commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
pnicolucci commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1149108909
I'll work to review this PR, if we're just doing minor javadoc clean up I don't see a problem with doing that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] volosied commented on a diff in pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
volosied commented on code in PR #268:
URL: https://github.com/apache/myfaces/pull/268#discussion_r888583110
##########
impl/pom.xml:
##########
@@ -953,8 +953,8 @@
</activation>
<build>
<plugins>
-
<plugin>
+ <groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<excludePackageNames>org.apache.myfaces.ee6</excludePackageNames>
Review Comment:
Thomas removed this, but I'm not sure if I should?
https://github.com/apache/myfaces/commit/1dbfe09efabfe174f8ec65f48d98fdec1e996fa4#diff-abb4e0d98dcc6e2742e9b46d0f75f831b0e0dbe1feac6a85ebf38167130528a9L873-L875
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] melloware commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
melloware commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1146014530
I had to update this to HTTPS:
```xml
<url>http://repository.apache.org/snapshots</url>
```
And I had to remove this entirely.
```xml
<repositories>
<!-- NOTE that apache.snapshots is defined in apache-parent -->
<!-- tomcat el-impl for test cases (see related tomcat-dependencies) -->
<repository>
<id>tomcat</id>
<url>http://tomcat.apache.org/dev/dist/m2-repository</url>
</repository>
</repositories>
```
To get it to build under Maven 3.6.3 or higher.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1151145851
```
Apache Maven 3.8.4 (9b656c72d54e5bacbed989b64718c159fe39b537)
Maven home: D:\Maven
Java version: 1.8.0_311, vendor: Oracle Corporation, runtime: C:\Program Files\Java\jdk1.8.0_311\jre
Default locale: de_DE, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
```
just works with mvn clean install
but javadoc:javadoc fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [myfaces] tandraschko commented on pull request #268: 2.2.x javadoc cleanup
Posted by GitBox <gi...@apache.org>.
tandraschko commented on PR #268:
URL: https://github.com/apache/myfaces/pull/268#issuecomment-1151157755
commited a fix now
this problemd occured since java8: https://stackoverflow.com/questions/15886209/maven-is-not-working-in-java-8-when-javadoc-tags-are-incomplete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@myfaces.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org