[GitHub] [dubbo] songxiaosheng commented on a diff in pull request #12273: Display indicator data in KEY, VALUE format

["songxiaosheng (via GitHub)" <gi...@apache.org>]

songxiaosheng commented on code in PR #12273:
URL: https://github.com/apache/dubbo/pull/12273#discussion_r1188589968


##########
dubbo-metrics/dubbo-metrics-default/pom.xml:
##########
@@ -46,5 +46,11 @@
             <artifactId>micrometer-tracing-integration-test</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.apache.dubbo</groupId>
+            <artifactId>dubbo-qos-api</artifactId>

Review Comment:
   指标模块作为基础设施，指标模块是否可以不依赖其他的具体模块，让其他模块来依赖指标模块



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org