You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by sb2nov <gi...@git.apache.org> on 2017/01/30 19:30:01 UTC

[GitHub] beam pull request #1869: [BEAM-886] Some performance improvements to NewDoFn

GitHub user sb2nov opened a pull request:

    https://github.com/apache/beam/pull/1869

    [BEAM-886] Some performance improvements to NewDoFn

    - Add types to some of variables for performance
    - Do minimal work in the process function by stashing the placeholders to be replaced.
    
    R: @robertwb PTAL
    CC: @aaltay
    
    ---
    
    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [x] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sb2nov/incubator-beam BEAM-886-Add-NewDoFn-class-1-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1869.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1869
    
----
commit 3427ee1da41ec1d42418615c1eac99be7ffe22a7
Author: Sourabh Bajaj <so...@google.com>
Date:   2017-01-30T19:16:16Z

    Some performance improvements to NewDoFn

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #1869: [BEAM-886] Some performance improvements to NewDoFn

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/1869


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---