You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/04 12:05:01 UTC

[GitHub] [flink] zentol commented on a change in pull request #14399: [FLINK-17827] [scala-shell] scala-shell.sh should fail early if no mo…

zentol commented on a change in pull request #14399:
URL: https://github.com/apache/flink/pull/14399#discussion_r551277730



##########
File path: flink-scala-shell/start-script/start-scala-shell.sh
##########
@@ -82,15 +82,15 @@ fi
 MODE=$1
 LOG=$FLINK_LOG_DIR/flink-$FLINK_IDENT_STRING-scala-shell-$MODE-$HOSTNAME.log
 
-if [[ ($MODE = "local") || ($MODE = "remote") ]]
+if [[ $MODE = "yarn" ]]
 then
-    LOG4J_CONFIG=log4j.properties
-    LOGBACK_CONFIG=logback.xml
-elif [[ $1 = "yarn" ]]
-then
-    LOG4J_CONFIG=log4j-session.properties
+	LOG4J_CONFIG=log4j-session.properties

Review comment:
       ```suggestion
       LOG4J_CONFIG=log4j-session.properties
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org