You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "David Capwell (Jira)" <ji...@apache.org> on 2020/04/20 19:36:00 UTC
[jira] [Comment Edited] (CASSANDRA-15674) liveDiskSpaceUsed and
totalDiskSpaceUsed get corrupted if IndexSummaryRedistribution gets
interrupted
[ https://issues.apache.org/jira/browse/CASSANDRA-15674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088022#comment-17088022 ]
David Capwell edited comment on CASSANDRA-15674 at 4/20/20, 7:35 PM:
---------------------------------------------------------------------
[~marcuse] pushed based off your feedback [here|https://github.com/apache/cassandra/pull/500/commits/27e5cd7132515ab0bd114731417913c40e4d7789]. The only change from your branch is I still verify totalDiskSpaceUsed (was removed from your patch, not sure why).
[Circle CI|https://circleci.com/workflow-run/c5d5c7c5-9c75-4e7e-a122-9771663e5451]
was (Author: dcapwell):
[~marcuse] pushed based off your feedback [here|https://github.com/apache/cassandra/pull/500/commits/27e5cd7132515ab0bd114731417913c40e4d7789]. The only change from your branch is I still verify totalDiskSpaceUsed (was removed from your patch, not sure why).
> liveDiskSpaceUsed and totalDiskSpaceUsed get corrupted if IndexSummaryRedistribution gets interrupted
> -----------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-15674
> URL: https://issues.apache.org/jira/browse/CASSANDRA-15674
> Project: Cassandra
> Issue Type: Bug
> Components: Local/Compaction, Observability/Metrics
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: 4.0-alpha
>
>
> IndexSummaryRedistribution is a compaction task and as such extends Holder and supports cancelation by throwing a CompactionInterruptedException. The issue is that IndexSummaryRedistribution tries to use transactions, but mutates the sstable in-place; transaction is unable to roll back.
> This would be fine (only updates summary) if it wasn’t for the fact the task attempts to also mutate the two metrics liveDiskSpaceUsed and totalDiskSpaceUsed, since these can’t be rolled back any cancelation could corrupt these metrics.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org