[GitHub] [airflow] jedcunningham commented on a diff in pull request #24054: Add param docs to KubernetesHook and KubernetesPodOperator (#23955)

[GitBox <gi...@apache.org>]

jedcunningham commented on code in PR #24054:
URL: https://github.com/apache/airflow/pull/24054#discussion_r887301319


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -112,6 +112,12 @@ class KubernetesPodOperator(BaseOperator):
     :param labels: labels to apply to the Pod. (templated)
     :param startup_timeout_seconds: timeout in seconds to startup the pod.
     :param get_logs: get the stdout of the container as logs of the tasks.
+    :param env_from: (Optional) List of sources to populate environment variables in the container.
+        The keys defined within a source must be a C_IDENTIFIER.
+        All invalid keys will be reported as an event when the container is starting.
+        When a key exists in multiple sources, the value associated with the last source
+        will take precedence. Values defined by an Env with a duplicate key will take precedence.
+        Cannot be updated.

Review Comment:
   I don't think these lines provide value for KPO. Also, this should be in the right spot below `env_vars`.
   ```suggestion
   ```



##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -143,6 +151,12 @@ class KubernetesPodOperator(BaseOperator):
     :param priority_class_name: priority class name for the launched Pod
     :param termination_grace_period: Termination grace period if task killed in UI,
         defaults to kubernetes default
+    :param pod_runtime_info_envs: (Optional) A list of environment variables,
+        to be set in the container. Cannot be updated.

Review Comment:
   ```suggestion
       :param pod_runtime_info_envs: (Optional) A list of environment variables,
           to be set in the container.
       :param termination_grace_period: Termination grace period if task killed in UI,
           defaults to kubernetes default
   ```
   
   Reordered, plus we don't need the 'Cannot be updated', as this doesn't make sense in the KPO context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org