You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2022/08/23 02:52:23 UTC

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Hello Wenzhe Zhou, Impala Public Jenkins,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/18889

to review the following change.


Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................

IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Some parts of HS2ColumnarResultSet were not prepared for returning
non-scalar types. This code only runs if impala.resultset.cache.size
is set, which is not the case in most of tests. The issue was caught
with Hue, which uses result caching.

Testing:
- Added a regression test in test_fetch_first.py, which contained
  other tests that used result caching.
- It turned out that some tests in the file did not run at all,
  as @needs_session() needs the parenthesis at the end. For this
  reason some test fixes were added to run them correctly, though
  these changes are totally unrelated to the current issue.

Backport issue:
- Test fails due to STRUCT in SelectList not supported on Parquet.
  Changed to use the corresponding ORC table.

Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Reviewed-on: http://gerrit.cloudera.org:8080/18768
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/service/query-result-set.cc
M tests/hs2/test_fetch_first.py
2 files changed, 49 insertions(+), 25 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/18889/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has removed a vote on this change.

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18889 )

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 10:57:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/18889 )

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 10:34:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18889 )

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8485/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 05:07:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18889 )

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................


Patch Set 2: Verified+1

> Patch Set 2: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8488/

The failed test is TestAcid.test_acid_compute_stats:
https://jenkins.impala.io/job/ubuntu-16.04-dockerised-tests/6203
It's tracked in IMPALA-11160 and unrelated to this patch. Merging this.


-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 22:20:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18889 )

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8488/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 10:57:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18889 )

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................

IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Some parts of HS2ColumnarResultSet were not prepared for returning
non-scalar types. This code only runs if impala.resultset.cache.size
is set, which is not the case in most of tests. The issue was caught
with Hue, which uses result caching.

Testing:
- Added a regression test in test_fetch_first.py, which contained
  other tests that used result caching.
- It turned out that some tests in the file did not run at all,
  as @needs_session() needs the parenthesis at the end. For this
  reason some test fixes were added to run them correctly, though
  these changes are totally unrelated to the current issue.

Backport issue:
- Test fails due to STRUCT in SelectList not supported on Parquet.
  Changed to use the corresponding ORC table.

Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Reviewed-on: http://gerrit.cloudera.org:8080/18768
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Wenzhe Zhou <wz...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-on: http://gerrit.cloudera.org:8080/18889
Tested-by: Quanlong Huang <hu...@gmail.com>
---
M be/src/service/query-result-set.cc
M tests/hs2/test_fetch_first.py
2 files changed, 49 insertions(+), 25 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Quanlong Huang: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18889 )

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8488/


-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 15:29:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/18889 )

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 07:49:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/18889 )

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................


Patch Set 1:

> Patch Set 1: Verified-1
> 
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8485/

The failure is in bin/gen-cscope.sh: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/17358/testReport/junit/generate_junitxml/build/dd4ed8bcce2f4f6482c62052304e5da4/
I think it's unrelated. Retriggering the job.


-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 10:57:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR](branch-4.1.1) IMPALA-11447: Fix crash when fetching arrays/structs with result caching

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18889 )

Change subject: IMPALA-11447: Fix crash when fetching arrays/structs with result caching
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/8485/


-- 
To view, visit http://gerrit.cloudera.org:8080/18889
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: branch-4.1.1
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4dd8f76187dc3555207e2d30d46d811e0a7a126
Gerrit-Change-Number: 18889
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 23 Aug 2022 09:17:02 +0000
Gerrit-HasComments: No