You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/21 11:52:29 UTC

[GitHub] [ignite] korlov42 commented on a change in pull request #9014: IGNITE-14573 DML operations failure.

korlov42 commented on a change in pull request #9014:
URL: https://github.com/apache/ignite/pull/9014#discussion_r617463961



##########
File path: modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/ExpressionFactoryImpl.java
##########
@@ -145,9 +147,19 @@ else if (collation.getFieldCollations().size() == 1)
 
         if (fieldCollation.direction == RelFieldCollation.Direction.ASCENDING) {
             return (o1, o2) -> {
-                final Comparable c1 = (Comparable)handler.get(x, o1);
-                final Comparable c2 = (Comparable)handler.get(x, o2);
-                return RelFieldCollation.compare(c1, c2, nullComparison);
+                Object obj1 = handler.get(x, o1);
+                Object obj2 = handler.get(x, o2);
+
+                boolean o1Comparable = o1 instanceof Comparable;

Review comment:
       `obj1`, not `o1`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org