You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/10 04:29:24 UTC

[GitHub] [arrow] kou commented on a diff in pull request #12763: ARROW-14892: [Python][C++] GCS Bindings

kou commented on code in PR #12763:
URL: https://github.com/apache/arrow/pull/12763#discussion_r894142479


##########
dev/tasks/python-wheels/github.osx.arm64.yml:
##########
@@ -134,6 +134,8 @@ jobs:
           $PYTHON -m venv test-arm64-env
           source test-arm64-env/bin/activate
           pip install --upgrade pip wheel
+          arch -arm64 pip install -r arrow/python/requirements-wheel-test.txt

Review Comment:
   Why the `$PYTHON` (`/Library/Frameworks/Python.framework/Versions/3.10/bin/python3.10`) is a x86 Python.
   If we don't use `arch -arm64`, wheels for x86 are installed.
   
   See https://github.com/ursacomputing/crossbow/runs/6165284883?check_suite_focus=true#step:10:147 for example:
   
   ```text
     Using cached MarkupSafe-2.1.1-cp310-cp310-macosx_10_9_x86_64.whl (13 kB)
   ```
   
   We can omit `arch -x86_64` in "Test Wheel on AMD64" but I think that we should specify `arch -x86_64` explicitly to work on macOS that provides arm64 system Python too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org