You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/18 15:55:54 UTC
[GitHub] [airflow] leonsmith opened a new pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
leonsmith opened a new pull request #15922:
URL: https://github.com/apache/airflow/pull/15922
Incorrect values where showing in the TaskInstance detail view because these columns where missing from the refresh_from_db method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15922:
URL: https://github.com/apache/airflow/pull/15922#issuecomment-881778769
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15922:
URL: https://github.com/apache/airflow/pull/15922#issuecomment-847233782
[The Workflow run](https://github.com/apache/airflow/actions/runs/872205715) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15922:
URL: https://github.com/apache/airflow/pull/15922#issuecomment-843470669
[The Workflow run](https://github.com/apache/airflow/actions/runs/854199086) is cancelling this PR. Building images for the PR has failed. Follow the workflow link to check the reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15922:
URL: https://github.com/apache/airflow/pull/15922#issuecomment-847234163
[The Workflow run](https://github.com/apache/airflow/actions/runs/872192677) is cancelling this PR. Building image for the PR has been cancelled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #15922:
URL: https://github.com/apache/airflow/pull/15922#issuecomment-885279568
Tests are failing @leonsmith
https://github.com/apache/airflow/pull/15922/checks?check_run_id=2663074502#step:6:11941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil edited a comment on pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #15922:
URL: https://github.com/apache/airflow/pull/15922#issuecomment-885279568
Tests are failing @leonsmith
https://github.com/apache/airflow/pull/15922/checks?check_run_id=2663074502#step:6:11941
```
for column in columns:
> assert getattr(ti, column.name) != 'NOT_REFRESHED'
E AssertionError: assert 'NOT_REFRESHED' != 'NOT_REFRESHED'
E + where 'NOT_REFRESHED' = getattr(<TaskInstance: test_refresh_from_db.op 2021-05-25 08:19:00.840850+00:00 [None]>, 'start_date')
E + where 'start_date' = Column('start_date', UtcDateTime(timezone=True), table=<task_instance>).name
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15922:
URL: https://github.com/apache/airflow/pull/15922#issuecomment-843562903
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #15922:
URL: https://github.com/apache/airflow/pull/15922#issuecomment-888379969
I think https://github.com/apache/airflow/pull/17179 does the same thing in a slightly different way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb closed pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
Posted by GitBox <gi...@apache.org>.
ashb closed pull request #15922:
URL: https://github.com/apache/airflow/pull/15922
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #15922: Add in extra columns to TaskInstance.refresh_from_db
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15922:
URL: https://github.com/apache/airflow/pull/15922#discussion_r634616931
##########
File path: tests/models/test_taskinstance.py
##########
@@ -2057,6 +2057,26 @@ def test_refresh_from_task(pool_override):
assert ti.operator == DummyOperator.__name__
+def test_refresh_from_db():
+ """
+ Test that all columns defined on the TaskInstance are refreshed form the db
Review comment:
```suggestion
Test that all columns defined on the TaskInstance are refreshed from the db
```
##########
File path: tests/models/test_taskinstance.py
##########
@@ -2057,6 +2057,26 @@ def test_refresh_from_task(pool_override):
assert ti.operator == DummyOperator.__name__
+def test_refresh_from_db():
+ """
+ Test that all columns defined on the TaskInstance are refreshed form the db
+ """
+ dag = DAG('dag', start_date=DEFAULT_DATE)
Review comment:
```suggestion
dag = DAG('test_refresh_from_db', start_date=DEFAULT_DATE)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org