You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/01/13 12:14:50 UTC

[GitHub] [calcite] danny0405 opened a new pull request #1754: [CALCITE-3730] Add hints to RelBuilder

danny0405 opened a new pull request #1754: [CALCITE-3730] Add hints to RelBuilder
URL: https://github.com/apache/calcite/pull/1754
 
 
   * Add hints to RelBuilder
   * In logical node classes that implement Hintable, add hints to #create method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] danny0405 commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder

Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder
URL: https://github.com/apache/calcite/pull/1754#discussion_r366147759
 
 

 ##########
 File path: cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSchema.java
 ##########
 @@ -140,7 +140,7 @@ public CassandraSchema(String host, int port, String keyspace, String username,
     this.parentSchema = parentSchema;
     this.name = name;
 
-    this.hook = Hook.TRIMMED.add(node -> {
+    this.hook = Hook.TRIMMED.addThread(node -> {
       CassandraSchema.this.addMaterializedViews();
     });
 
 Review comment:
   Fix the compile warnings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] vlsi commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder

Posted by GitBox <gi...@apache.org>.
vlsi commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder
URL: https://github.com/apache/calcite/pull/1754#discussion_r366179960
 
 

 ##########
 File path: cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSchema.java
 ##########
 @@ -140,7 +140,7 @@ public CassandraSchema(String host, int port, String keyspace, String username,
     this.parentSchema = parentSchema;
     this.name = name;
 
-    this.hook = Hook.TRIMMED.add(node -> {
+    this.hook = Hook.TRIMMED.addThread(node -> {
       CassandraSchema.this.addMaterializedViews();
     });
 
 Review comment:
   I guess @michaelmior could clarify better.
   
   I've no idea what this does and I have very little understanding of how Calcite adapter works.
   What I know is `Hook#add` adds a static (cross-thread) hook, which typically interferes when concurrent execution is used (e.g. when tests are executed concurrently).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] danny0405 commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder

Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #1754: [CALCITE-3730] Add hints to RelBuilder
URL: https://github.com/apache/calcite/pull/1754#discussion_r366160219
 
 

 ##########
 File path: cassandra/src/main/java/org/apache/calcite/adapter/cassandra/CassandraSchema.java
 ##########
 @@ -140,7 +140,7 @@ public CassandraSchema(String host, int port, String keyspace, String username,
     this.parentSchema = parentSchema;
     this.name = name;
 
-    this.hook = Hook.TRIMMED.add(node -> {
+    this.hook = Hook.TRIMMED.addThread(node -> {
       CassandraSchema.this.addMaterializedViews();
     });
 
 Review comment:
   @vlsi Can you help to see this problem ? when i try to replace the `add` with `addThread`, the jdk8 tests failed because of the concurrent modification exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [calcite] danny0405 merged pull request #1754: [CALCITE-3730] Add hints to RelBuilder

Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #1754: [CALCITE-3730] Add hints to RelBuilder
URL: https://github.com/apache/calcite/pull/1754
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services