You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by GitBox <gi...@apache.org> on 2021/04/20 01:10:41 UTC

[GitHub] [datasketches-cpp] alexey-milovidov opened a new issue #211: The library is not UBSan friendly.

alexey-milovidov opened a new issue #211:
URL: https://github.com/apache/datasketches-cpp/issues/211


   Unaligned memory access: https://github.com/apache/datasketches-cpp/compare/master...ClickHouse-Extras:master#diff-4ea6027998b11271d4276f9293495215f94937fbd8ac0aa2c8395d83778753f1L81


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-cpp] jmalkin commented on issue #211: The library is not UBSan friendly.

Posted by GitBox <gi...@apache.org>.
jmalkin commented on issue #211:
URL: https://github.com/apache/datasketches-cpp/issues/211#issuecomment-822929265


   Do you have a minimum test case that fails? I was unable to reproduce this when running locally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-cpp] AlexanderSaydakov commented on issue #211: The library is not UBSan friendly.

Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on issue #211:
URL: https://github.com/apache/datasketches-cpp/issues/211#issuecomment-823731727


   @jmalkin It may or may not fail depending on platform and compiler. UBSan catches undefined behavior that potentially might fail somewhere.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-cpp] AlexanderSaydakov closed issue #211: The library is not UBSan friendly.

Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov closed issue #211:
URL: https://github.com/apache/datasketches-cpp/issues/211


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-cpp] AlexanderSaydakov commented on issue #211: The library is not UBSan friendly.

Posted by GitBox <gi...@apache.org>.
AlexanderSaydakov commented on issue #211:
URL: https://github.com/apache/datasketches-cpp/issues/211#issuecomment-823733392


   @alexey-milovidov Would you like to submit a pull request or would you like us to apply your suggested patch? Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-cpp] alexey-milovidov commented on issue #211: The library is not UBSan friendly.

Posted by GitBox <gi...@apache.org>.
alexey-milovidov commented on issue #211:
URL: https://github.com/apache/datasketches-cpp/issues/211#issuecomment-824000494


   It's ok if you commit this patch under your name. My collegue will share an example, but only tomorrow.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org


[GitHub] [datasketches-cpp] jmalkin commented on issue #211: The library is not UBSan friendly.

Posted by GitBox <gi...@apache.org>.
jmalkin commented on issue #211:
URL: https://github.com/apache/datasketches-cpp/issues/211#issuecomment-823762917


   @AlexanderSaydakov yes, I added flags to compile and link with UBSan and ASan using `-fcoverage` options and found nothing. I may well be doing something incorrectly, of course.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org