You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "András Belicza (JIRA)" <ji...@apache.org> on 2008/07/07 06:51:31 UTC
[jira] Created: (HARMONY-5898) Progress on policytool
Progress on policytool
----------------------
Key: HARMONY-5898
URL: https://issues.apache.org/jira/browse/HARMONY-5898
Project: Harmony
Issue Type: Improvement
Components: JDK
Environment: Should run in all environment.
Reporter: András Belicza
Priority: Minor
Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
-BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
-BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
-Edited policy file is displayed in a text field.
-Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
-ListAndEditPanel which provides a listing and editing interface for various entities.
This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
-The New menu works now
-GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5898) Progress on policytool
Posted by "András Belicza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611165#action_12611165 ]
András Belicza commented on HARMONY-5898:
-----------------------------------------
There might be extra spaces for 2 reasons:
-I finally set up my eclipse not to use tabs but spaces only. I think that's the expected operational.
-If a class has 2 methods for example and there's an empty separator between the 2 methods, I usually put 4 spaces in that line (1 tab) so it has the same identation as other rows in the declaration of the class. Is this not intended? Should I use empty lines there with no spaces? And what about inside 1 method? If I have an empty tagging-separator line between 2 operations in a method, should it be an empty line without spaces too? I guess it's prefered to have as many spaces as other lines in that method for identation.
So which one should I use?
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Assignee: Sian January
> Priority: Minor
> Attachments: policytool 2008.07.07.patch, screenshot-1.jpg
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5898) Progress on policytool
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January closed HARMONY-5898.
---------------------------------
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Assignee: Sian January
> Priority: Minor
> Fix For: 5.0M7
>
> Attachments: policytool 2008.07.07.patch, policytool 2008.07.08 empty lines.patch, screenshot-1.jpg
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5898) Progress on policytool
Posted by "András Belicza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
András Belicza updated HARMONY-5898:
------------------------------------
Attachment: policytool 2008.07.07.patch
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Priority: Minor
> Attachments: policytool 2008.07.07.patch
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5898) Progress on policytool
Posted by "András Belicza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
András Belicza updated HARMONY-5898:
------------------------------------
Attachment: policytool 2008.07.08 empty lines.patch
I removed spaces from the separator lines.
I override-and-updated before creating this new patch, there is no need to the previous patch "policytool 2008.07.07.patch" (but that info is probably contained in the patch).
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Assignee: Sian January
> Priority: Minor
> Attachments: policytool 2008.07.07.patch, policytool 2008.07.08 empty lines.patch, screenshot-1.jpg
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5898) Progress on policytool
Posted by "András Belicza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611168#action_12611168 ]
András Belicza commented on HARMONY-5898:
-----------------------------------------
All right, I correct it and submit a new patch.
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Assignee: Sian January
> Priority: Minor
> Attachments: policytool 2008.07.07.patch, screenshot-1.jpg
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5898) Progress on policytool
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611166#action_12611166 ]
Sian January commented on HARMONY-5898:
---------------------------------------
It's better that blank lines have no spaces on at all.
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Assignee: Sian January
> Priority: Minor
> Attachments: policytool 2008.07.07.patch, screenshot-1.jpg
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5898) Progress on policytool
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January resolved HARMONY-5898.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M7
Slightly modified patch applied at r674840.
Re formatting - for if/else blocks we tend to put the else on the same line as the closing bracket for the if statement, but I've done that for you as I didn't mention it in my previous comment (hence the slightly modified patch).
Please check that it was applied as you expected apart from this change.
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Assignee: Sian January
> Priority: Minor
> Fix For: 5.0M7
>
> Attachments: policytool 2008.07.07.patch, policytool 2008.07.08 empty lines.patch, screenshot-1.jpg
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5898) Progress on policytool
Posted by "András Belicza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
András Belicza updated HARMONY-5898:
------------------------------------
Attachment: screenshot-1.jpg
This is how policytool looked like on July 7, 2008.
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Priority: Minor
> Attachments: policytool 2008.07.07.patch, screenshot-1.jpg
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5898) Progress on policytool
Posted by "András Belicza (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12612294#action_12612294 ]
András Belicza commented on HARMONY-5898:
-----------------------------------------
Looks fine to me.
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Assignee: Sian January
> Priority: Minor
> Fix For: 5.0M7
>
> Attachments: policytool 2008.07.07.patch, policytool 2008.07.08 empty lines.patch, screenshot-1.jpg
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5898) Progress on policytool
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sian January reassigned HARMONY-5898:
-------------------------------------
Assignee: Sian January
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Assignee: Sian January
> Priority: Minor
> Attachments: policytool 2008.07.07.patch, screenshot-1.jpg
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5898) Progress on policytool
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12611161#action_12611161 ]
Sian January commented on HARMONY-5898:
---------------------------------------
Thanks for this contribution Andras, it looks like you have made some good progress. I've tried it out and it's working for me now with and without a "-file" argument, but unfortunately the patch isn't very clean. You have several files where the patch is adding extra spaces onto empty lines. If you can upload a clean patch I'll be happy to commit it.
> Progress on policytool
> ----------------------
>
> Key: HARMONY-5898
> URL: https://issues.apache.org/jira/browse/HARMONY-5898
> Project: Harmony
> Issue Type: Improvement
> Components: JDK
> Environment: Should run in all environment.
> Reporter: András Belicza
> Assignee: Sian January
> Priority: Minor
> Attachments: policytool 2008.07.07.patch, screenshot-1.jpg
>
>
> Changes and new development compared to: https://issues.apache.org/jira/browse/HARMONY-5886
> -BaseFormDialog: represents a base form dialog which will be used to query data of policy entries
> -BaseFormDialog is used for KeystoreEntryEditFormDialog to inherit from, to create a form dialog to view and edit the keystore and the keystore password url entries.
> -Edited policy file is displayed in a text field.
> -Central check and confirmation for unsaved changes before certain operations (exit, open file, start new file).
> -ListAndEditPanel which provides a listing and editing interface for various entities.
> This will be used to list and to provide an entry point for editing grant entries, permissions, principals.
> -The New menu works now
> -GrantEntry and its parts (permissions, principals) are created.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.