You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/06/19 03:16:40 UTC
[GitHub] [dolphinscheduler] SbloodyS opened a new pull request, #10499: [Doc] Add api test doc
SbloodyS opened a new pull request, #10499:
URL: https://github.com/apache/dolphinscheduler/pull/10499
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
#10442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on a diff in pull request #10499: [Doc] Add api test doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on code in PR #10499:
URL: https://github.com/apache/dolphinscheduler/pull/10499#discussion_r901042614
##########
docs/docs/en/development/api-test.md:
##########
@@ -0,0 +1,94 @@
+# DolphinScheduler API Automation Test
+
+## I. Preparatory knowledge
+
+### 1. The difference between API Test and Unit Test
Review Comment:
we should avoid using the number in markdown title, because the leading number `#` already represented this
```suggestion
### The difference between API Test and Unit Test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie merged pull request #10499: [Doc] Add api test doc
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #10499:
URL: https://github.com/apache/dolphinscheduler/pull/10499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10499: [Doc] Add api test doc
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10499:
URL: https://github.com/apache/dolphinscheduler/pull/10499#discussion_r901043153
##########
docs/docs/en/development/api-test.md:
##########
@@ -0,0 +1,94 @@
+# DolphinScheduler API Automation Test
+
+## I. Preparatory knowledge
+
+### 1. The difference between API Test and Unit Test
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10499: [Doc] Add api test doc
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10499:
URL: https://github.com/apache/dolphinscheduler/pull/10499#discussion_r901042724
##########
docs/docs/en/development/api-test.md:
##########
@@ -0,0 +1,94 @@
+# DolphinScheduler API Automation Test
+
+## I. Preparatory knowledge
+
+### 1. The difference between API Test and Unit Test
Review Comment:
I'll fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org