You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wilder Rodrigues <WR...@schubergphilis.com> on 2015/07/01 09:35:20 UTC
Re: [PROPOSAL] Commit to master through PR only
Nice!
I spent couple of hours this morning to review a few PRs.
But we still have too many of them and not many people reviewing/testing, which makes the process a bit slow.
>From the guys who usually review PRs, who is currently on holidays?
Cheers,
Wilder
> On 29 Jun 2015, at 11:27, sebgoa <ru...@gmail.com> wrote:
>
> Ok we are on,
>
> Starting today, commit to master through PR only.
> 2 LGTM needed for merge.
> If Travis fails, we can still merge given a good explanation of why (since travis has issues once in a while).
>
> I will keep an eye on commit, at least once a day, and ping the list if I see a commit that went in without a PR.
>
> thanks, let's give this a shot, goal being of course to stabilize master for 4.6.
>
> Everyone should start testing master as if it were a release branch now.
>
> -sebastien
>
>
> On Jun 28, 2015, at 9:17 AM, Remi Bergsma <re...@remi.nl> wrote:
>
>> Let’s do it!
>>
>> Starting tomorrow we’ll commit to master through PR only (as described below), and we’ll evaluate this at Sept 30, 2015.
>>
>> I’ll put a reminder in my schedule to start the thread.
>>
>> Regards,
>> Remi
>>
>>> On 26 jun. 2015, at 23:10, Daan Hoogland <da...@gmail.com> wrote:
>>>
>>> date := 2015-09-30 ???
>>>
>>> On Fri, Jun 26, 2015 at 9:54 PM, David Nalley <da...@gnsa.us> wrote:
>>>> On Thu, Jun 25, 2015 at 10:38 AM, Sebastien Goasguen <ru...@gmail.com> wrote:
>>>>> Folks,
>>>>>
>>>>> A few of us are in Amsterdam at DevOps days. We are chatting about release management procedure.
>>>>> Remi is working on a set of principles that he will put on the wiki to start a [DISCUSS].
>>>>>
>>>>> However to get started on the right track. I would like to propose the following easy step:
>>>>>
>>>>> Starting Monday June 29th (next monday):
>>>>>
>>>>> - Only commit through PR will land on master (after a minimum of 2 LGTM and green Travis results)
>>>>> - Direct commit will be reverted
>>>>> - Any committer can merge the PR.
>>>>>
>>>>> Goal being to start having a new practice -everything through PR for everyone- which is an easy way to gate our own commits building up to a PR.
>>>>>
>>>>> There is no tooling involved, just human agreement.
>>>>>
>>>>> cheers,
>>>>>
>>>>> -Sebastien
>>>>
>>>> In general, +1
>>>> I think we should set a time, say a month or two out, to review how
>>>> well it has worked, and what we need to tweak to make things better. I
>>>> think we should be explicit with this so that we can say 'On $date'
>>>> we'll start a thread to talk about what has and hasn't worked and how
>>>> we can improve this.
>>>>
>>>> --David
>>>
>>>
>>>
>>> --
>>> Daan
>>
>
Re: [PROPOSAL] Commit to master through PR only
Posted by David Nalley <da...@gnsa.us>.
On Wed, Jul 1, 2015 at 3:39 AM, sebgoa <ru...@gmail.com> wrote:
>
> On Jul 1, 2015, at 9:35 AM, Wilder Rodrigues <WR...@schubergphilis.com> wrote:
>
>> Nice!
>>
>> I spent couple of hours this morning to review a few PRs.
>>
>> But we still have too many of them and not many people reviewing/testing, which makes the process a bit slow.
>>
>
> I expect this week to get slow. It's July 4th week end in the US.
>
> And it's a new process.
>
> IMHO there is no problem in being a little slow and having a back log of PRs as long as it make releasing faster.
>
> And it will motivate everyone to review.
>
Having seen this work in a few other communities, it will create a
currency out of reviews. (and that's a good thing)
You'll review someones PR in exchange for their review. People will
come to the list asking for their review to get some attention.
We'll end up having a weekly(?) PR-athon, etc.
--David
Re: [PROPOSAL] Commit to master through PR only
Posted by sebgoa <ru...@gmail.com>.
On Jul 1, 2015, at 9:35 AM, Wilder Rodrigues <WR...@schubergphilis.com> wrote:
> Nice!
>
> I spent couple of hours this morning to review a few PRs.
>
> But we still have too many of them and not many people reviewing/testing, which makes the process a bit slow.
>
I expect this week to get slow. It's July 4th week end in the US.
And it's a new process.
IMHO there is no problem in being a little slow and having a back log of PRs as long as it make releasing faster.
And it will motivate everyone to review.
> From the guys who usually review PRs, who is currently on holidays?
>
> Cheers,
> Wilder
>
>
>> On 29 Jun 2015, at 11:27, sebgoa <ru...@gmail.com> wrote:
>>
>> Ok we are on,
>>
>> Starting today, commit to master through PR only.
>> 2 LGTM needed for merge.
>> If Travis fails, we can still merge given a good explanation of why (since travis has issues once in a while).
>>
>> I will keep an eye on commit, at least once a day, and ping the list if I see a commit that went in without a PR.
>>
>> thanks, let's give this a shot, goal being of course to stabilize master for 4.6.
>>
>> Everyone should start testing master as if it were a release branch now.
>>
>> -sebastien
>>
>>
>> On Jun 28, 2015, at 9:17 AM, Remi Bergsma <re...@remi.nl> wrote:
>>
>>> Let’s do it!
>>>
>>> Starting tomorrow we’ll commit to master through PR only (as described below), and we’ll evaluate this at Sept 30, 2015.
>>>
>>> I’ll put a reminder in my schedule to start the thread.
>>>
>>> Regards,
>>> Remi
>>>
>>>> On 26 jun. 2015, at 23:10, Daan Hoogland <da...@gmail.com> wrote:
>>>>
>>>> date := 2015-09-30 ???
>>>>
>>>> On Fri, Jun 26, 2015 at 9:54 PM, David Nalley <da...@gnsa.us> wrote:
>>>>> On Thu, Jun 25, 2015 at 10:38 AM, Sebastien Goasguen <ru...@gmail.com> wrote:
>>>>>> Folks,
>>>>>>
>>>>>> A few of us are in Amsterdam at DevOps days. We are chatting about release management procedure.
>>>>>> Remi is working on a set of principles that he will put on the wiki to start a [DISCUSS].
>>>>>>
>>>>>> However to get started on the right track. I would like to propose the following easy step:
>>>>>>
>>>>>> Starting Monday June 29th (next monday):
>>>>>>
>>>>>> - Only commit through PR will land on master (after a minimum of 2 LGTM and green Travis results)
>>>>>> - Direct commit will be reverted
>>>>>> - Any committer can merge the PR.
>>>>>>
>>>>>> Goal being to start having a new practice -everything through PR for everyone- which is an easy way to gate our own commits building up to a PR.
>>>>>>
>>>>>> There is no tooling involved, just human agreement.
>>>>>>
>>>>>> cheers,
>>>>>>
>>>>>> -Sebastien
>>>>>
>>>>> In general, +1
>>>>> I think we should set a time, say a month or two out, to review how
>>>>> well it has worked, and what we need to tweak to make things better. I
>>>>> think we should be explicit with this so that we can say 'On $date'
>>>>> we'll start a thread to talk about what has and hasn't worked and how
>>>>> we can improve this.
>>>>>
>>>>> --David
>>>>
>>>>
>>>>
>>>> --
>>>> Daan
>>>
>>
>