You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by da...@apache.org on 2025/02/04 13:39:30 UTC

(kafka) branch trunk updated: MINOR: Fix PerformanceService sys test (#18797)

This is an automated email from the ASF dual-hosted git repository.

dajac pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 4c6af67eb1e MINOR: Fix PerformanceService sys test (#18797)
4c6af67eb1e is described below

commit 4c6af67eb1efdee321490a9efbb92bf5d61fb868
Author: David Jacot <da...@gmail.com>
AuthorDate: Tue Feb 4 14:39:24 2025 +0100

    MINOR: Fix PerformanceService sys test (#18797)
    
    This patch fixes the PerformanceService system test which was still using ZK.
    
    ```
    ================================================================================
    SESSION REPORT (ALL TESTS)
    ducktape version: 0.12.0
    session_id:       2025-02-04--003
    run time:         1 minute 42.629 seconds
    tests run:        4
    passed:           4                                                                                                                                                                         flaky:            0
    failed:           0                                                                                                                                                                         ignored:          0
    ================================================================================
    ```
    
    Reviewers: Chia-Ping Tsai <ch...@gmail.com>
---
 tests/kafkatest/sanity_checks/test_performance_services.py | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/tests/kafkatest/sanity_checks/test_performance_services.py b/tests/kafkatest/sanity_checks/test_performance_services.py
index 27e732edfb5..239c173a509 100644
--- a/tests/kafkatest/sanity_checks/test_performance_services.py
+++ b/tests/kafkatest/sanity_checks/test_performance_services.py
@@ -20,7 +20,6 @@ from ducktape.tests.test import Test
 from kafkatest.services.kafka import KafkaService, quorum
 from kafkatest.services.performance import ProducerPerformanceService, ConsumerPerformanceService, EndToEndLatencyService
 from kafkatest.services.performance import latency, compute_aggregate_throughput
-from kafkatest.services.zookeeper import ZookeeperService
 from kafkatest.version import DEV_BRANCH, LATEST_2_1, KafkaVersion
 
 
@@ -31,14 +30,8 @@ class PerformanceServiceTest(Test):
         self.num_records = 10000
         self.topic = "topic"
 
-        self.zk = ZookeeperService(test_context, 1) if quorum.for_test(test_context) == quorum.zk else None
-
-    def setUp(self):
-        if self.zk:
-            self.zk.start()
-
     @cluster(num_nodes=5)
-    @matrix(version=[str(LATEST_2_1), str(DEV_BRANCH)], metadata_quorum=quorum.all)
+    @matrix(version=[str(LATEST_2_1), str(DEV_BRANCH)], metadata_quorum=quorum.all_kraft)
     def test_version(self, version=str(LATEST_2_1), metadata_quorum=quorum.zk):
         """
         Sanity check out producer performance service - verify that we can run the service with a small
@@ -47,7 +40,7 @@ class PerformanceServiceTest(Test):
         version = KafkaVersion(version)
         self.kafka = KafkaService(
             self.test_context, 1,
-            self.zk, topics={self.topic: {'partitions': 1, 'replication-factor': 1}}, version=DEV_BRANCH)
+            None, topics={self.topic: {'partitions': 1, 'replication-factor': 1}}, version=DEV_BRANCH)
         self.kafka.start()
 
         # check basic run of producer performance