You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by st...@apache.org on 2012/05/12 01:32:12 UTC

svn commit: r1337412 - in /hbase/branches/0.92: CHANGES.txt src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java

Author: stack
Date: Fri May 11 23:32:11 2012
New Revision: 1337412

URL: http://svn.apache.org/viewvc?rev=1337412&view=rev
Log:
HBASE-5922 HalfStoreFileReader seekBefore causes StackOverflowError

Modified:
    hbase/branches/0.92/CHANGES.txt
    hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java

Modified: hbase/branches/0.92/CHANGES.txt
URL: http://svn.apache.org/viewvc/hbase/branches/0.92/CHANGES.txt?rev=1337412&r1=1337411&r2=1337412&view=diff
==============================================================================
--- hbase/branches/0.92/CHANGES.txt (original)
+++ hbase/branches/0.92/CHANGES.txt Fri May 11 23:32:11 2012
@@ -61,6 +61,7 @@ Release 0.92.2 - Unreleased
    HBASE-5928  Hbck shouldn't npe when there are no tables (Elliott Clark)
    HBASE-5894  Table deletion failed but HBaseAdmin#deletetable reports it as success (Xufeng)
    HBASE-5942  HConnnectionManager.getRegionServerWithRetries doesn't call afterCall properly
+   HBASE-5922  HalfStoreFileReader seekBefore causes StackOverflowError (Nate Putnam)
 
   IMPROVEMENTS
    HBASE-5592  Make it easier to get a table from shell (Ben West)

Modified: hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java
URL: http://svn.apache.org/viewvc/hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java?rev=1337412&r1=1337411&r2=1337412&view=diff
==============================================================================
--- hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java (original)
+++ hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/HalfStoreFileReader.java Fri May 11 23:32:11 2012
@@ -144,9 +144,10 @@ public class HalfStoreFileReader extends
             return false;
           }
         } else {
+          // The equals sign isn't strictly necessary just here to be consistent with seekTo
           if (getComparator().compare(key, offset, length, splitkey, 0,
               splitkey.length) >= 0) {
-            return seekBefore(splitkey, 0, splitkey.length);
+            return this.delegate.seekBefore(splitkey, 0, splitkey.length);
           }
         }
         return this.delegate.seekBefore(key, offset, length);