You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "PetrovMikhail (JIRA)" <ji...@apache.org> on 2019/01/10 09:41:00 UTC

[jira] [Assigned] (IGNITE-10178) change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")

     [ https://issues.apache.org/jira/browse/IGNITE-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

PetrovMikhail reassigned IGNITE-10178:
--------------------------------------

    Assignee: Oleg Ignatenko  (was: PetrovMikhail)

> change tests that fail("Ignite JIRA ticket URL") to @Ignore("Ignite JIRA ticket URL")
> -------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10178
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10178
>             Project: Ignite
>          Issue Type: Sub-task
>            Reporter: Oleg Ignatenko
>            Assignee: Oleg Ignatenko
>            Priority: Major
>
> Change tests that use {{fail("Ignite JIRA ticket URL")}} to {{@Ignore("Ignite JIRA ticket URL")}}. Do the same change for tests that fail by {{@IgniteIgnore("Ignite JIRA ticket URL")}}, like for example [S3CheckpointSpiStartStopSelfTest.testStartStop|https://github.com/apache/ignite/blob/master/modules/aws/src/test/java/org/apache/ignite/spi/checkpoint/s3/S3CheckpointSpiStartStopSelfTest.java]. Also, use [Ignore|http://junit.sourceforge.net/javadoc/org/junit/Ignore.html] to annotate empty test classes in examples that were discovered and re-muted per IGNITE-10174.
> If needed, refer parent task for more details.
> Note this step would better be coordinated with Teamcity and TC bot maintainers because it may substantially impact them.
> -----
> Note that tests that are expected to be ignored depending on runtime conditions should be rewritten to use {{Assume}} instead of {{fail}}. So that old code...
> {code}if (someRuntimeCondition())
>     fail("Ignite JIRA ticket URL");{code}
> ...will change to
> {code}Assume.assumeFalse("Ignite JIRA ticket URL", someRuntimeCondition());{code}
> (this change can be "extracted" into separate JIRA task if it is more convenient). Readers interested to find more details about how {{Assume}} works can find more details and code snippet [in comments here|https://issues.apache.org/jira/browse/IGNITE-10178?focusedCommentId=16723863&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-16723863].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)