You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Mariia Mykhailova (JIRA)" <ji...@apache.org> on 2017/01/03 23:16:58 UTC
[jira] [Commented] (REEF-1663) Fix
TestKMeansOnDirectRunViaFileSystem failure in AppVeyor
[ https://issues.apache.org/jira/browse/REEF-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15796518#comment-15796518 ]
Mariia Mykhailova commented on REEF-1663:
-----------------------------------------
Interestingly, the test fails again: https://ci.appveyor.com/project/tcNickolas/reef/build/461-master/job/tx6w93r7o9i3q7i7/tests
This time we know that new loss is at least 1E-6 greater than old loss. Is it possible that we have an actual bug in the KMeans code?
> Fix TestKMeansOnDirectRunViaFileSystem failure in AppVeyor
> ----------------------------------------------------------
>
> Key: REEF-1663
> URL: https://issues.apache.org/jira/browse/REEF-1663
> Project: REEF
> Issue Type: Sub-task
> Components: REEF.NET
> Reporter: Mariia Mykhailova
> Assignee: Mariia Mykhailova
> Priority: Minor
> Fix For: 0.16
>
>
> {{O.A.R.Tests.Functional.ML.KMeans.TestKMeans.TestKMeansOnDirectRunViaFileSystem}} [failed on AppVeyor|https://ci.appveyor.com/project/ApacheSoftwareFoundation/reef/build/1124-master/job/j85983ju7qyytgdc/tests] with error
> {noformat}
> System.InvalidOperationException : The new loss 14658.95 is larger than previous loss 14658.95, while loss function must be monotonically decreasing across iterations
> {noformat}
> I doubt that the new loss was really significantly less than the previous one, since the displayed values are identical. But the test uses exact comparisons of floating-point numbers, which occasionally might produce unexpected results.
> We should probably replace exact comparisons with a proper comparison function, as described [here|http://stackoverflow.com/questions/3874627/floating-point-comparison-functions-for-c-sharp]. Note that this comparison is done in two files - {{TestKMeans.cs}} and {{KMeansMasterTask.cs}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)