[jira] [Commented] (OOZIE-2338) Invalid configuration defined reported for some valid configs

["Andras Salamon (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809591#comment-16809591 ] 

Andras Salamon commented on OOZIE-2338:
---------------------------------------

[~nobigo] Thanks for the new patch.
 * For {{HCAT_CONFIGURATION}} the solution of the old patch (by [~rkanter]) was to add the property to {{oozie-default.xml}}. Your patch just adds it to the exception list. Why?
 * If we add {{HCAT_CONFIGURATION}} to to exception list: Why do you use {{contains}} for {{HCAT_CONFIGURATION}} checking? Why not {{equals}}?
 * If we need to use {{startsWith}} and {{equals}} (or {{contains}}) at the same time, then I think we should you regexp matches instead.
 * Could you please also check the whitespace formatting. For instance spaces after {{for}}, {{if}}...

My biggest concern is the fact that we may miss a few other properties, I don't really know any foolproof way to list all the properties missing from {{oozie-default.xml}} We have discussed this issue with [~kmarton] and opened OOZIE-3462. I think it might be useful to fix OOZIE-3462 first. That requires to checks lots of code, we might find a few more special properties.

> Invalid configuration defined reported for some valid configs
> -------------------------------------------------------------
>
>                 Key: OOZIE-2338
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2338
>             Project: Oozie
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 4.2.0
>            Reporter: Robert Kanter
>            Assignee: duan xiong
>            Priority: Major
>         Attachments: OOZIE-2338.001.patch, OOZIE-2338.002.patch, oozie-2338-003.patch, oozie-2338-004.patch, oozie-2338-005.patch
>
>
> OOZIE-1890 moved all default config values from the code and oozie-site into oozie-default; it also added a WARN message on startup when a config is found in oozie-site that's not defined in oozie-default.  
> However, this can produce some false positives.  In particular, we observed these:
> {noformat}
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.email.smtp.auth]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.email.smtp.host]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.service.HCatAccessorService.hcat.configuration]
> 2015-08-18 01:16:32,365 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.email.from.address]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.service.ProxyUserService.proxyuser.hue.hosts]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.service.GroupsService.hadoop.security.group.mapping]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.email.smtp.port]
> 2015-08-18 01:16:32,366 WARN org.apache.oozie.service.ConfigurationService: SERVER[<redacted>] Invalid configuration defined, [oozie.service.ProxyUserService.proxyuser.hue.groups]
> {noformat}
> While harmful, these messages may be concerning or confusing for users.
> Some of these are simply missing from oozie-default (because they have no default value?), while others such as the ProxyUserService configs, will require special handling because the property name can vary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)