You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org> on 2017/01/05 19:28:10 UTC
[kudu-CR](branch-1.2.x) KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
Jean-Daniel Cryans has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5612
Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
......................................................................
KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
kudu-spark2 pom.xml is malformed due to a maven shade plugin issue:
dependency-reduced-pom should use shadedArtifactId
(https://issues.apache.org/jira/browse/MSHADE-155)
I upgraded maven-shade-plugin to version 2.4 and fixed the pom.xml.
Additionally, I moved the default properties to a default profile.
This makes the property settings consistent for both versions.
Change-Id: I0dc9ac261a82e13d189bc1be04faea5a9812d518
Reviewed-on: http://gerrit.cloudera.org:8080/5586
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
(cherry picked from commit 33b1de3eebc19c1be908f6f2d56cda2fe3cde995)
---
M java/kudu-spark/pom.xml
1 file changed, 15 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/5612/1
--
To view, visit http://gerrit.cloudera.org:8080/5612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0dc9ac261a82e13d189bc1be04faea5a9812d518
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jun He <ju...@gmail.com>
[kudu-CR](branch-1.2.x) KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0dc9ac261a82e13d189bc1be04faea5a9812d518
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jun He <ju...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR](branch-1.2.x) KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
Posted by "Jean-Daniel Cryans (Code Review)" <ge...@cloudera.org>.
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
......................................................................
KUDU-1817. Fix kudu-spark2 artifactId in pom.xml
kudu-spark2 pom.xml is malformed due to a maven shade plugin issue:
dependency-reduced-pom should use shadedArtifactId
(https://issues.apache.org/jira/browse/MSHADE-155)
I upgraded maven-shade-plugin to version 2.4 and fixed the pom.xml.
Additionally, I moved the default properties to a default profile.
This makes the property settings consistent for both versions.
Change-Id: I0dc9ac261a82e13d189bc1be04faea5a9812d518
Reviewed-on: http://gerrit.cloudera.org:8080/5586
Tested-by: Kudu Jenkins
Reviewed-by: Will Berkeley <wd...@gmail.com>
(cherry picked from commit 33b1de3eebc19c1be908f6f2d56cda2fe3cde995)
Reviewed-on: http://gerrit.cloudera.org:8080/5612
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M java/kudu-spark/pom.xml
1 file changed, 15 insertions(+), 11 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5612
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0dc9ac261a82e13d189bc1be04faea5a9812d518
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>