You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "mrhhsg (via GitHub)" <gi...@apache.org> on 2026/04/24 03:46:43 UTC
[PR] [fix](be) Fix exchange receiver dependency race [doris]
mrhhsg opened a new pull request, #62777:
URL: https://github.com/apache/doris/pull/62777
### What problem does this PR solve?
Issue Number: None
Related PR: None
Problem Summary: Data or EOS could arrive after the receiver is registered but before its source dependency is installed. In that window, ready notification was lost and the exchange source could remain blocked. Recheck the queue state when setting the dependency and protect channel turn-off checks with the instance mutex.
### Release note
Fix a potential query hang caused by an exchange receiver dependency ready-notification race.
### Check List (For Author)
- Test: Unit Test / Manual test
- Unit Test: ./run-be-ut.sh --run --filter=DataStreamRecvrTest.TestEosBeforeSetDependency:DataStreamRecvrTest.TestDataBeforeSetDependencyWithRemainingSenders
- Manual test: build-support/check-format.sh
- Static analysis attempted: build-support/run-clang-tidy.sh --build-dir be/ut_build_ASAN failed because clang-tidy could not analyze the files due to environment/pre-existing diagnostics, including missing stddef.h from system/libstdc++ headers and an existing unmatched NOLINTEND in be/src/core/types.h
- Behavior changed: Yes. Exchange source dependencies are now marked ready if queued data or EOS arrived before set_dependency().
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4311656015
# BE UT Coverage Report
Increment line coverage `64.71% (11/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/192b5260433fd460cb5587a08517675b7b808c7c_192b5260433fd460cb5587a08517675b7b808c7c/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/192b5260433fd460cb5587a08517675b7b808c7c_192b5260433fd460cb5587a08517675b7b808c7c/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.31% (20385/38238) |
| Line Coverage | 36.85% (192020/521089) |
| Region Coverage | 33.18% (149390/450268) |
| Branch Coverage | 34.29% (65333/190556) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4310463654
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4327854080
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4326119183
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4314595969
# BE Regression && UT Coverage Report
Increment line coverage `88.24% (15/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62777_192b5260433fd460cb5587a08517675b7b808c7c_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62777_192b5260433fd460cb5587a08517675b7b808c7c_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.44% (26773/37477) |
| Line Coverage | 53.76% (279400/519700) |
| Region Coverage | 47.16% (214934/455765) |
| Branch Coverage | 50.42% (97190/192778) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4328830447
# BE Regression && UT Coverage Report
Increment line coverage `83.33% (10/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62777_8d32bae24898cf3aec34e096edae6f8a54158b2e_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62777_8d32bae24898cf3aec34e096edae6f8a54158b2e_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.92% (26971/37500) |
| Line Coverage | 55.13% (286826/520268) |
| Region Coverage | 52.12% (237194/455124) |
| Branch Coverage | 53.53% (102507/191506) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4326118653
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4311677923
# BE Regression && UT Coverage Report
Increment line coverage `88.24% (15/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62777_192b5260433fd460cb5587a08517675b7b808c7c_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62777_192b5260433fd460cb5587a08517675b7b808c7c_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.45% (26777/37477) |
| Line Coverage | 53.81% (279642/519700) |
| Region Coverage | 47.19% (215069/455765) |
| Branch Coverage | 50.46% (97271/192778) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "mrhhsg (via GitHub)" <gi...@apache.org>.
mrhhsg commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4310619378
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4310463437
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4312800602
# BE UT Coverage Report
Increment line coverage `64.71% (11/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/192b5260433fd460cb5587a08517675b7b808c7c_192b5260433fd460cb5587a08517675b7b808c7c/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/192b5260433fd460cb5587a08517675b7b808c7c_192b5260433fd460cb5587a08517675b7b808c7c/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.35% (20400/38241) |
| Line Coverage | 36.88% (192237/521196) |
| Region Coverage | 33.19% (149509/450465) |
| Branch Coverage | 34.32% (65433/190648) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4314555985
# BE UT Coverage Report
Increment line coverage `64.71% (11/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/192b5260433fd460cb5587a08517675b7b808c7c_192b5260433fd460cb5587a08517675b7b808c7c/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/192b5260433fd460cb5587a08517675b7b808c7c_192b5260433fd460cb5587a08517675b7b808c7c/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.36% (20414/38256) |
| Line Coverage | 36.89% (192296/521255) |
| Region Coverage | 33.22% (149665/450480) |
| Branch Coverage | 34.32% (65435/190648) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4312821822
# BE Regression && UT Coverage Report
Increment line coverage `88.24% (15/17)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/62777_192b5260433fd460cb5587a08517675b7b808c7c_merge/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/62777_192b5260433fd460cb5587a08517675b7b808c7c_merge/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 71.44% (26773/37477) |
| Line Coverage | 53.76% (279395/519700) |
| Region Coverage | 47.15% (214880/455765) |
| Branch Coverage | 50.41% (97189/192778) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #62777:
URL: https://github.com/apache/doris/pull/62777#issuecomment-4328390939
# BE UT Coverage Report
Increment line coverage `50.00% (6/12)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/8d32bae24898cf3aec34e096edae6f8a54158b2e_8d32bae24898cf3aec34e096edae6f8a54158b2e/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/8d32bae24898cf3aec34e096edae6f8a54158b2e_8d32bae24898cf3aec34e096edae6f8a54158b2e/report/index.html)
| Category | Coverage |
|-------------------|--------------------|
| Function Coverage | 53.34% (20417/38275) |
| Line Coverage | 36.90% (192471/521563) |
| Region Coverage | 33.22% (149766/450798) |
| Branch Coverage | 34.34% (65516/190776) |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](be) Fix exchange receiver dependency race [doris]
Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #62777:
URL: https://github.com/apache/doris/pull/62777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org