You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Akira AJISAKA (JIRA)" <ji...@apache.org> on 2014/11/12 03:43:34 UTC
[jira] [Commented] (HADOOP-10365) BufferedOutputStream in
FileUtil#unpackEntries() should be closed in finally block
[ https://issues.apache.org/jira/browse/HADOOP-10365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207585#comment-14207585 ]
Akira AJISAKA commented on HADOOP-10365:
----------------------------------------
bq. So, need to cleanup.
Agree. The patch looks mostly good. Minor nits:
1.
{code}
+ } catch (IOException e) {
+ throw e;
{code}
These lines are no-op, so they can be removed.
2.
{code}
+ outputStream = new BufferedOutputStream(new FileOutputStream(outputFile))
{code}
Would you please render the line within 80 characters?
> BufferedOutputStream in FileUtil#unpackEntries() should be closed in finally block
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-10365
> URL: https://issues.apache.org/jira/browse/HADOOP-10365
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Reporter: Ted Yu
> Priority: Minor
> Attachments: HADOOP-10365.2.patch, HADOOP-10365.patch
>
>
> {code}
> BufferedOutputStream outputStream = new BufferedOutputStream(
> new FileOutputStream(outputFile));
> ...
> outputStream.flush();
> outputStream.close();
> {code}
> outputStream should be closed in finally block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)