You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/09 14:13:52 UTC
[GitHub] [dubbo-go] ChangedenCZD opened a new pull request #1370: Ftr: Add config loader hooks
ChangedenCZD opened a new pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
Hook Type:
- BeforeShutdownHook
- BeforeConsumerConnectHook
- ConsumerConnectSuccessHook
- ConsumerConnectFailHook
- AllConsumerConnectCompleteHook
- BeforeProviderConnectHook
- ProviderConnectSuccessHook
- ProviderConnectFailHook
- AllProviderConnectCompleteHook
Create Instance:
- NewBeforeShutdownHook(func() {})
- NewBeforeConsumerConnectHook(func(info *ConsumerConnectInfo) {})
- NewConsumerConnectSuccessHook(func(info *ConsumerConnectInfo) {})
- NewConsumerConnectFailHook(func(info *ConsumerConnectFailInfo) {})
- NewAllConsumersConnectCompleteHook(func() {})
- NewBeforeProviderConnectHook(func(info *ProviderConnectInfo) {})
- NewProviderConnectSuccessHook(func(info *ProviderConnectInfo) {})
- NewProviderConnectFailHook(func(info *ProviderConnectFailInfo) {})
- NewAllProvidersConnectCompleteHook(func() {})
Add/Remove Hooks:
- config.AddLoaderHooks(...hooks)
- config.RemoveLoaderHooks(...hooks)
Unit Test:
- config_loader_test.TestLoadWithLoaderHooks
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #1364
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
None
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1370: Ftr: Add config loader hooks
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895331705
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1370](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef8680c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c5802c521a1cbb2752330d2064375622fe97f54f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5802c5) will **increase** coverage by `0.14%`.
> The diff coverage is `69.06%`.
> :exclamation: Current head ef8680c differs from pull request most recent head d1cb244. Consider uploading reports for the commit d1cb244 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1370 +/- ##
==========================================
+ Coverage 54.95% 55.09% +0.14%
==========================================
Files 272 273 +1
Lines 14755 14935 +180
==========================================
+ Hits 8109 8229 +120
- Misses 5769 5825 +56
- Partials 877 881 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `72.63% <0.00%> (-1.57%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `52.34% <64.44%> (+2.34%)` | :arrow_up: |
| [config/config\_loader\_hook.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfaG9vay5nbw==) | `71.64% <71.64%> (ø)` | |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.90% <0.00%> (-5.31%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.82% <0.00%> (-2.20%)` | :arrow_down: |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `100.00% <0.00%> (+13.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5802c5...d1cb244](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1370: Ftr: Add config loader hooks
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895331705
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1370](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (975f356) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c5802c521a1cbb2752330d2064375622fe97f54f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5802c5) will **increase** coverage by `0.06%`.
> The diff coverage is `69.06%`.
> :exclamation: Current head 975f356 differs from pull request most recent head e3e2264. Consider uploading reports for the commit e3e2264 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1370 +/- ##
==========================================
+ Coverage 54.95% 55.02% +0.06%
==========================================
Files 272 273 +1
Lines 14755 14935 +180
==========================================
+ Hits 8109 8218 +109
- Misses 5769 5839 +70
- Partials 877 878 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `72.63% <0.00%> (-1.57%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `52.34% <64.44%> (+2.34%)` | :arrow_up: |
| [config/config\_loader\_hook.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfaG9vay5nbw==) | `71.64% <71.64%> (ø)` | |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (-7.95%)` | :arrow_down: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.90% <0.00%> (-5.31%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.82% <0.00%> (-2.20%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+1.85%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `78.04% <0.00%> (+2.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5802c5...e3e2264](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692640869
##########
File path: config/config_loader_hook.go
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+ "fmt"
+ "reflect"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+)
+
+const (
+ hookParams = constant.HookParams
+)
+
+type LoaderHook interface {
+ emit() bool
+ // if you want to use emitWithParams, you must add HookParams field and make emit return false
+ emitWithParams(params interface{}) bool
+}
+
+func getLoaderHookType(t LoaderHook) reflect.Type {
+ hookType := reflect.TypeOf(t)
+ if reflect.Ptr == hookType.Kind() {
+ hookType = hookType.Elem()
+ }
+ return hookType
+}
+
+func getLoaderHookTypeString(t LoaderHook) string {
+ return getLoaderHookType(t).String()
+}
+
+func getLoaderHookInfo(v reflect.Value) reflect.Value {
+ if reflect.Ptr == v.Kind() {
+ v = v.Elem()
+ }
+ return v
+}
+
+func getLoaderHookParams(t LoaderHook) interface{} {
Review comment:
I have no idea why we need use to reflection here to retrieve params. `emitHook` with an extra argument receiving the params is a better choice, like `emitHook(t LoaderHook, params interface{})`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD commented on pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
ChangedenCZD commented on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-907246956
暂时先关闭，后期改进
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692640869
##########
File path: config/config_loader_hook.go
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+ "fmt"
+ "reflect"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+)
+
+const (
+ hookParams = constant.HookParams
+)
+
+type LoaderHook interface {
+ emit() bool
+ // if you want to use emitWithParams, you must add HookParams field and make emit return false
+ emitWithParams(params interface{}) bool
+}
+
+func getLoaderHookType(t LoaderHook) reflect.Type {
+ hookType := reflect.TypeOf(t)
+ if reflect.Ptr == hookType.Kind() {
+ hookType = hookType.Elem()
+ }
+ return hookType
+}
+
+func getLoaderHookTypeString(t LoaderHook) string {
+ return getLoaderHookType(t).String()
+}
+
+func getLoaderHookInfo(v reflect.Value) reflect.Value {
+ if reflect.Ptr == v.Kind() {
+ v = v.Elem()
+ }
+ return v
+}
+
+func getLoaderHookParams(t LoaderHook) interface{} {
Review comment:
I have no idea why we need use to reflection here to retrieve params. `emitHook` with an extra argument to receive the params is a better choice, like `emitHook(t LoaderHook, params interface{})`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD closed pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
ChangedenCZD closed pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1370: Ftr: Add config loader hooks
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895331705
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1370](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (975f356) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c5802c521a1cbb2752330d2064375622fe97f54f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5802c5) will **increase** coverage by `0.06%`.
> The diff coverage is `69.06%`.
> :exclamation: Current head 975f356 differs from pull request most recent head d1cb244. Consider uploading reports for the commit d1cb244 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1370 +/- ##
==========================================
+ Coverage 54.95% 55.02% +0.06%
==========================================
Files 272 273 +1
Lines 14755 14935 +180
==========================================
+ Hits 8109 8218 +109
- Misses 5769 5839 +70
- Partials 877 878 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `72.63% <0.00%> (-1.57%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `52.34% <64.44%> (+2.34%)` | :arrow_up: |
| [config/config\_loader\_hook.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfaG9vay5nbw==) | `71.64% <71.64%> (ø)` | |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (-7.95%)` | :arrow_down: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.90% <0.00%> (-5.31%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.82% <0.00%> (-2.20%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+1.85%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `78.04% <0.00%> (+2.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5802c5...d1cb244](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895331705
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1370](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fec318c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c5802c521a1cbb2752330d2064375622fe97f54f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5802c5) will **increase** coverage by `0.23%`.
> The diff coverage is `75.55%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1370 +/- ##
==========================================
+ Coverage 54.95% 55.19% +0.23%
==========================================
Files 272 273 +1
Lines 14755 14934 +179
==========================================
+ Hits 8109 8243 +134
- Misses 5769 5812 +43
- Partials 877 879 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `72.63% <0.00%> (-1.57%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `52.52% <65.90%> (+2.52%)` | :arrow_up: |
| [config/config\_loader\_hook.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfaG9vay5nbw==) | `79.85% <79.85%> (ø)` | |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.90% <0.00%> (-5.31%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+1.85%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `78.04% <0.00%> (+2.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5802c5...fec318c](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692637827
##########
File path: config/config_loader_hook.go
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+ "fmt"
+ "reflect"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+)
+
+const (
+ hookParams = constant.HookParams
+)
+
+type LoaderHook interface {
+ emit() bool
+ // if you want to use emitWithParams, you must add HookParams field and make emit return false
+ emitWithParams(params interface{}) bool
+}
+
+func getLoaderHookType(t LoaderHook) reflect.Type {
+ hookType := reflect.TypeOf(t)
+ if reflect.Ptr == hookType.Kind() {
+ hookType = hookType.Elem()
+ }
+ return hookType
+}
+
+func getLoaderHookTypeString(t LoaderHook) string {
+ return getLoaderHookType(t).String()
+}
+
+func getLoaderHookInfo(v reflect.Value) reflect.Value {
+ if reflect.Ptr == v.Kind() {
+ v = v.Elem()
+ }
+ return v
+}
+
+func getLoaderHookParams(t LoaderHook) interface{} {
+ hookType := getLoaderHookType(t)
+ _, existed := hookType.FieldByName(hookParams)
+ if !existed {
+ panic(fmt.Sprintf("Hook field [%s] not existed for %s", hookParams, hookType.Name()))
+ }
+ hookParams := getLoaderHookInfo(reflect.ValueOf(t)).FieldByName(hookParams)
+ return getLoaderHookInfo(hookParams).Interface()
+}
+
+func AddLoaderHooks(hooks ...LoaderHook) {
+ if len(hooks) > 0 {
+ if loaderHooks == nil {
+ loaderHooks = map[string][]LoaderHook{}
+ }
+ for _, hook := range hooks {
+ hookType := getLoaderHookTypeString(hook)
+ var hooks []LoaderHook
+ if hs, ok := loaderHooks[hookType]; ok {
+ hooks = hs
+ }
+ if hooks == nil {
+ hooks = []LoaderHook{}
+ }
+ loaderHooks[hookType] = append(hooks, hook)
+ }
+ }
+}
+
+func RemoveLoaderHooks(hooks ...LoaderHook) {
+ if loaderHooks != nil && len(loaderHooks) > 0 {
+ for _, rmHook := range hooks {
+ hookType := getLoaderHookTypeString(rmHook)
+ if hooks, ok := loaderHooks[hookType]; ok {
+ for index, targetHook := range hooks {
+ if rmHook == targetHook {
+ newHooks := append(hooks[:index], hooks[index+1:]...)
+ if len(newHooks) == 0 {
+ delete(loaderHooks, hookType)
+ } else {
+ loaderHooks[hookType] = newHooks
+ }
+ break
Review comment:
```go
if len(newHooks) == 1 {
delete(loaderHooks, hookType)
} else {
loaderHooks[hookType] = append(loaderHooks[hookType][:index], loaderHooks[hookType][index+1:]...)
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692678588
##########
File path: config/config_loader_hook.go
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+ "fmt"
+ "reflect"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+)
+
+const (
+ hookParams = constant.HookParams
Review comment:
use `constant.HookParams` directly please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692640869
##########
File path: config/config_loader_hook.go
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+ "fmt"
+ "reflect"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+)
+
+const (
+ hookParams = constant.HookParams
+)
+
+type LoaderHook interface {
+ emit() bool
+ // if you want to use emitWithParams, you must add HookParams field and make emit return false
+ emitWithParams(params interface{}) bool
+}
+
+func getLoaderHookType(t LoaderHook) reflect.Type {
+ hookType := reflect.TypeOf(t)
+ if reflect.Ptr == hookType.Kind() {
+ hookType = hookType.Elem()
+ }
+ return hookType
+}
+
+func getLoaderHookTypeString(t LoaderHook) string {
+ return getLoaderHookType(t).String()
+}
+
+func getLoaderHookInfo(v reflect.Value) reflect.Value {
+ if reflect.Ptr == v.Kind() {
+ v = v.Elem()
+ }
+ return v
+}
+
+func getLoaderHookParams(t LoaderHook) interface{} {
Review comment:
I have no idea why we need use to reflection here to retrieve params. `emitHook` using an extra argument to receive hook params is a better choice, like `emitHook(t LoaderHook, params interface{})`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD commented on pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
ChangedenCZD commented on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895801988
> 1. Could you pls shortly describe how your hooks work?
> 2. Pls change base branch from 3.0 to 1.5, as our 3.0 config is in refactor progress and will add this feature later. @ChangedenCZD
#1372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692636887
##########
File path: config/config_loader.go
##########
@@ -59,6 +59,8 @@ var (
confBaseFile string
uniformVirtualServiceConfigPath string
uniformDestRuleConfigPath string
+
+ loaderHooks map[string][]LoaderHook
Review comment:
Why not initializes `loaderHooks` here? If not initializes, you should handle the case that `loaderHooks` is empty in `AddLoaderHooks` and `RemoveLoaderHooks` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1370: Ftr: Add config loader hooks
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895331705
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1370](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (78c26e7) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c5802c521a1cbb2752330d2064375622fe97f54f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5802c5) will **increase** coverage by `0.14%`.
> The diff coverage is `67.66%`.
> :exclamation: Current head 78c26e7 differs from pull request most recent head ef8680c. Consider uploading reports for the commit ef8680c to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1370 +/- ##
==========================================
+ Coverage 54.95% 55.10% +0.14%
==========================================
Files 272 273 +1
Lines 14755 14921 +166
==========================================
+ Hits 8109 8222 +113
- Misses 5769 5823 +54
+ Partials 877 876 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `72.63% <0.00%> (-1.57%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `52.34% <64.44%> (+2.34%)` | :arrow_up: |
| [config/config\_loader\_hook.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfaG9vay5nbw==) | `70.00% <70.00%> (ø)` | |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.90% <0.00%> (-5.31%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `41.37% <0.00%> (-3.45%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.82% <0.00%> (-2.20%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+1.85%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `78.04% <0.00%> (+2.43%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5802c5...ef8680c](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1370: Ftr: Add config loader hooks
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895331705
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1370](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef8680c) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c5802c521a1cbb2752330d2064375622fe97f54f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5802c5) will **increase** coverage by `0.14%`.
> The diff coverage is `69.06%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1370 +/- ##
==========================================
+ Coverage 54.95% 55.09% +0.14%
==========================================
Files 272 273 +1
Lines 14755 14935 +180
==========================================
+ Hits 8109 8229 +120
- Misses 5769 5825 +56
- Partials 877 881 +4
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `72.63% <0.00%> (-1.57%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `52.34% <64.44%> (+2.34%)` | :arrow_up: |
| [config/config\_loader\_hook.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfaG9vay5nbw==) | `71.64% <71.64%> (ø)` | |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.90% <0.00%> (-5.31%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.82% <0.00%> (-2.20%)` | :arrow_down: |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `100.00% <0.00%> (+13.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5802c5...ef8680c](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1370: Ftr: Add config loader hooks
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895331705
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1370](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (78c26e7) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c5802c521a1cbb2752330d2064375622fe97f54f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5802c5) will **increase** coverage by `0.14%`.
> The diff coverage is `67.66%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1370 +/- ##
==========================================
+ Coverage 54.95% 55.10% +0.14%
==========================================
Files 272 273 +1
Lines 14755 14921 +166
==========================================
+ Hits 8109 8222 +113
- Misses 5769 5823 +54
+ Partials 877 876 -1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `72.63% <0.00%> (-1.57%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `52.34% <64.44%> (+2.34%)` | :arrow_up: |
| [config/config\_loader\_hook.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfaG9vay5nbw==) | `70.00% <70.00%> (ø)` | |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.90% <0.00%> (-5.31%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `41.37% <0.00%> (-3.45%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.82% <0.00%> (-2.20%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+1.85%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `78.04% <0.00%> (+2.43%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5802c5...78c26e7](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692633485
##########
File path: config/config_loader_hook.go
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+ "fmt"
+ "reflect"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+)
+
+const (
+ hookParams = constant.HookParams
+)
+
+type LoaderHook interface {
+ emit() bool
+ // if you want to use emitWithParams, you must add HookParams field and make emit return false
+ emitWithParams(params interface{}) bool
+}
+
+func getLoaderHookType(t LoaderHook) reflect.Type {
+ hookType := reflect.TypeOf(t)
+ if reflect.Ptr == hookType.Kind() {
+ hookType = hookType.Elem()
+ }
+ return hookType
+}
+
+func getLoaderHookTypeString(t LoaderHook) string {
+ return getLoaderHookType(t).String()
+}
+
+func getLoaderHookInfo(v reflect.Value) reflect.Value {
+ if reflect.Ptr == v.Kind() {
+ v = v.Elem()
+ }
+ return v
+}
+
+func getLoaderHookParams(t LoaderHook) interface{} {
+ hookType := getLoaderHookType(t)
+ _, existed := hookType.FieldByName(hookParams)
+ if !existed {
+ panic(fmt.Sprintf("Hook field [%s] not existed for %s", hookParams, hookType.Name()))
+ }
+ hookParams := getLoaderHookInfo(reflect.ValueOf(t)).FieldByName(hookParams)
+ return getLoaderHookInfo(hookParams).Interface()
+}
+
+func AddLoaderHooks(hooks ...LoaderHook) {
+ if len(hooks) > 0 {
+ if loaderHooks == nil {
+ loaderHooks = map[string][]LoaderHook{}
+ }
+ for _, hook := range hooks {
+ hookType := getLoaderHookTypeString(hook)
+ var hooks []LoaderHook
+ if hs, ok := loaderHooks[hookType]; ok {
+ hooks = hs
+ }
+ if hooks == nil {
+ hooks = []LoaderHook{}
+ }
+ loaderHooks[hookType] = append(hooks, hook)
+ }
Review comment:
It seems that `hooks` is a useless variable in this case.
```go
if _, ok := loaderHooks[hookType]; !ok {
loaderHooks[hookType] = make([]LoaderHook)
}
loaderHooks[hookType] = append(loaderHooks[hookType], hook)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] ChangedenCZD edited a comment on pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
ChangedenCZD edited a comment on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895801988
> 1. Could you pls shortly describe how your hooks work?
> 2. Pls change base branch from 3.0 to 1.5, as our 3.0 config is in refactor progress and will add this feature later. @ChangedenCZD
@LaurenceLiZhixin #1372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895331705
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1370](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (975f356) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c5802c521a1cbb2752330d2064375622fe97f54f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5802c5) will **increase** coverage by `0.06%`.
> The diff coverage is `69.06%`.
> :exclamation: Current head 975f356 differs from pull request most recent head b6df560. Consider uploading reports for the commit b6df560 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1370 +/- ##
==========================================
+ Coverage 54.95% 55.02% +0.06%
==========================================
Files 272 273 +1
Lines 14755 14935 +180
==========================================
+ Hits 8109 8218 +109
- Misses 5769 5839 +70
- Partials 877 878 +1
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `72.63% <0.00%> (-1.57%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `52.34% <64.44%> (+2.34%)` | :arrow_up: |
| [config/config\_loader\_hook.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfaG9vay5nbw==) | `71.64% <71.64%> (ø)` | |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `26.49% <0.00%> (-7.95%)` | :arrow_down: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.90% <0.00%> (-5.31%)` | :arrow_down: |
| [cluster/cluster\_impl/failback\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvZmFpbGJhY2tfY2x1c3Rlcl9pbnZva2VyLmdv) | `75.82% <0.00%> (-2.20%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+1.85%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `78.04% <0.00%> (+2.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5802c5...b6df560](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692637827
##########
File path: config/config_loader_hook.go
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+ "fmt"
+ "reflect"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+)
+
+const (
+ hookParams = constant.HookParams
+)
+
+type LoaderHook interface {
+ emit() bool
+ // if you want to use emitWithParams, you must add HookParams field and make emit return false
+ emitWithParams(params interface{}) bool
+}
+
+func getLoaderHookType(t LoaderHook) reflect.Type {
+ hookType := reflect.TypeOf(t)
+ if reflect.Ptr == hookType.Kind() {
+ hookType = hookType.Elem()
+ }
+ return hookType
+}
+
+func getLoaderHookTypeString(t LoaderHook) string {
+ return getLoaderHookType(t).String()
+}
+
+func getLoaderHookInfo(v reflect.Value) reflect.Value {
+ if reflect.Ptr == v.Kind() {
+ v = v.Elem()
+ }
+ return v
+}
+
+func getLoaderHookParams(t LoaderHook) interface{} {
+ hookType := getLoaderHookType(t)
+ _, existed := hookType.FieldByName(hookParams)
+ if !existed {
+ panic(fmt.Sprintf("Hook field [%s] not existed for %s", hookParams, hookType.Name()))
+ }
+ hookParams := getLoaderHookInfo(reflect.ValueOf(t)).FieldByName(hookParams)
+ return getLoaderHookInfo(hookParams).Interface()
+}
+
+func AddLoaderHooks(hooks ...LoaderHook) {
+ if len(hooks) > 0 {
+ if loaderHooks == nil {
+ loaderHooks = map[string][]LoaderHook{}
+ }
+ for _, hook := range hooks {
+ hookType := getLoaderHookTypeString(hook)
+ var hooks []LoaderHook
+ if hs, ok := loaderHooks[hookType]; ok {
+ hooks = hs
+ }
+ if hooks == nil {
+ hooks = []LoaderHook{}
+ }
+ loaderHooks[hookType] = append(hooks, hook)
+ }
+ }
+}
+
+func RemoveLoaderHooks(hooks ...LoaderHook) {
+ if loaderHooks != nil && len(loaderHooks) > 0 {
+ for _, rmHook := range hooks {
+ hookType := getLoaderHookTypeString(rmHook)
+ if hooks, ok := loaderHooks[hookType]; ok {
+ for index, targetHook := range hooks {
+ if rmHook == targetHook {
+ newHooks := append(hooks[:index], hooks[index+1:]...)
+ if len(newHooks) == 0 {
+ delete(loaderHooks, hookType)
+ } else {
+ loaderHooks[hookType] = newHooks
+ }
+ break
Review comment:
```go
if len(newHooks) == 1 {
delete(loaderHooks, hookType)
} else {
loaderHooks[hookType] = append(hooks[:index], hooks[index+1:]...)
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] LaurenceLiZhixin commented on pull request #1370: Ftr: Add config loader hooks
Posted by GitBox <gi...@apache.org>.
LaurenceLiZhixin commented on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895741506
1. Could you pls shortly describe how your hooks work?
2. Pls change base branch from 3.0 to 1.5, as our 3.0 config is in refactor progress and will add this feature later. @ChangedenCZD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692640869
##########
File path: config/config_loader_hook.go
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+ "fmt"
+ "reflect"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+)
+
+const (
+ hookParams = constant.HookParams
+)
+
+type LoaderHook interface {
+ emit() bool
+ // if you want to use emitWithParams, you must add HookParams field and make emit return false
+ emitWithParams(params interface{}) bool
+}
+
+func getLoaderHookType(t LoaderHook) reflect.Type {
+ hookType := reflect.TypeOf(t)
+ if reflect.Ptr == hookType.Kind() {
+ hookType = hookType.Elem()
+ }
+ return hookType
+}
+
+func getLoaderHookTypeString(t LoaderHook) string {
+ return getLoaderHookType(t).String()
+}
+
+func getLoaderHookInfo(v reflect.Value) reflect.Value {
+ if reflect.Ptr == v.Kind() {
+ v = v.Elem()
+ }
+ return v
+}
+
+func getLoaderHookParams(t LoaderHook) interface{} {
Review comment:
I have no idea why we need use to reflection here to retrieve params. `emitHook` using an extra argument to receive hook params is a better choice, like `emitHook(t LoaderHook, params interface{})`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#issuecomment-895331705
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1370](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d0ff10b) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/c5802c521a1cbb2752330d2064375622fe97f54f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c5802c5) will **increase** coverage by `0.10%`.
> The diff coverage is `69.44%`.
> :exclamation: Current head d0ff10b differs from pull request most recent head fec318c. Consider uploading reports for the commit fec318c to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0 #1370 +/- ##
==========================================
+ Coverage 54.95% 55.06% +0.10%
==========================================
Files 272 273 +1
Lines 14755 14934 +179
==========================================
+ Hits 8109 8223 +114
- Misses 5769 5836 +67
+ Partials 877 875 -2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/graceful\_shutdown.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duLmdv) | `72.63% <0.00%> (-1.57%)` | :arrow_down: |
| [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `52.52% <65.90%> (+2.52%)` | :arrow_up: |
| [config/config\_loader\_hook.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXJfaG9vay5nbw==) | `71.64% <71.64%> (ø)` | |
| [cluster/cluster\_impl/base\_cluster\_invoker.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2x1c3Rlci9jbHVzdGVyX2ltcGwvYmFzZV9jbHVzdGVyX2ludm9rZXIuZ28=) | `50.00% <0.00%> (-12.77%)` | :arrow_down: |
| [remoting/etcdv3/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2xpc3RlbmVyLmdv) | `46.90% <0.00%> (-5.31%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `52.83% <0.00%> (ø)` | |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `80.55% <0.00%> (+1.85%)` | :arrow_up: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `78.04% <0.00%> (+2.43%)` | :arrow_up: |
| [filter/metrics/filter.go](https://codecov.io/gh/apache/dubbo-go/pull/1370/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL21ldHJpY3MvZmlsdGVyLmdv) | `100.00% <0.00%> (+13.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c5802c5...fec318c](https://codecov.io/gh/apache/dubbo-go/pull/1370?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] xavier-niu commented on a change in pull request #1370: Ftr: Add config loader hooks for 3.0
Posted by GitBox <gi...@apache.org>.
xavier-niu commented on a change in pull request #1370:
URL: https://github.com/apache/dubbo-go/pull/1370#discussion_r692637827
##########
File path: config/config_loader_hook.go
##########
@@ -0,0 +1,367 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package config
+
+import (
+ "fmt"
+ "reflect"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/common/constant"
+)
+
+const (
+ hookParams = constant.HookParams
+)
+
+type LoaderHook interface {
+ emit() bool
+ // if you want to use emitWithParams, you must add HookParams field and make emit return false
+ emitWithParams(params interface{}) bool
+}
+
+func getLoaderHookType(t LoaderHook) reflect.Type {
+ hookType := reflect.TypeOf(t)
+ if reflect.Ptr == hookType.Kind() {
+ hookType = hookType.Elem()
+ }
+ return hookType
+}
+
+func getLoaderHookTypeString(t LoaderHook) string {
+ return getLoaderHookType(t).String()
+}
+
+func getLoaderHookInfo(v reflect.Value) reflect.Value {
+ if reflect.Ptr == v.Kind() {
+ v = v.Elem()
+ }
+ return v
+}
+
+func getLoaderHookParams(t LoaderHook) interface{} {
+ hookType := getLoaderHookType(t)
+ _, existed := hookType.FieldByName(hookParams)
+ if !existed {
+ panic(fmt.Sprintf("Hook field [%s] not existed for %s", hookParams, hookType.Name()))
+ }
+ hookParams := getLoaderHookInfo(reflect.ValueOf(t)).FieldByName(hookParams)
+ return getLoaderHookInfo(hookParams).Interface()
+}
+
+func AddLoaderHooks(hooks ...LoaderHook) {
+ if len(hooks) > 0 {
+ if loaderHooks == nil {
+ loaderHooks = map[string][]LoaderHook{}
+ }
+ for _, hook := range hooks {
+ hookType := getLoaderHookTypeString(hook)
+ var hooks []LoaderHook
+ if hs, ok := loaderHooks[hookType]; ok {
+ hooks = hs
+ }
+ if hooks == nil {
+ hooks = []LoaderHook{}
+ }
+ loaderHooks[hookType] = append(hooks, hook)
+ }
+ }
+}
+
+func RemoveLoaderHooks(hooks ...LoaderHook) {
+ if loaderHooks != nil && len(loaderHooks) > 0 {
+ for _, rmHook := range hooks {
+ hookType := getLoaderHookTypeString(rmHook)
+ if hooks, ok := loaderHooks[hookType]; ok {
+ for index, targetHook := range hooks {
+ if rmHook == targetHook {
+ newHooks := append(hooks[:index], hooks[index+1:]...)
+ if len(newHooks) == 0 {
+ delete(loaderHooks, hookType)
+ } else {
+ loaderHooks[hookType] = newHooks
+ }
+ break
Review comment:
```go
if len(loaderHooks[hookType]) == 1 {
delete(loaderHooks, hookType)
} else {
loaderHooks[hookType] = append(loaderHooks[hookType][:index], loaderHooks[hookType][index+1:]...)
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org