You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Viet Hung Nguyen (JIRA)" <ji...@apache.org> on 2007/06/25 04:26:25 UTC
[jira] Created: (GERONIMO-3258) ability to delete db pools
ability to delete db pools
--------------------------
Key: GERONIMO-3258
URL: https://issues.apache.org/jira/browse/GERONIMO-3258
Project: Geronimo
Issue Type: Improvement
Security Level: public (Regular issues)
Components: usability
Affects Versions: 2.0-M6
Environment: windows xp
Reporter: Viet Hung Nguyen
Right now, there is only the option to Edit a DB Pool. It will be useful if we can delete a DB Pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (GERONIMO-3258) ability to delete db pools
Posted by "Jay D. McHugh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12507902 ]
Jay D. McHugh commented on GERONIMO-3258:
-----------------------------------------
I took a quick look at this and it does work to delete database pools.
But, there should be some protection added to prevent the user from deleting one of the 'built in'
pools (NoTxDatasource and SystemDatasource) otherwise the system can be made unusable.
(BTW, there was a way to delete datasources - But it was in the un-obvious location of
'J2EE Connectors'. Being able to delete database pools from the database pool screen
is much more user-friendly)
> ability to delete db pools
> --------------------------
>
> Key: GERONIMO-3258
> URL: https://issues.apache.org/jira/browse/GERONIMO-3258
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console, databases, usability
> Affects Versions: 2.0-M6
> Environment: windows xp
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3258.patch
>
>
> Right now, there is only the option to Edit a DB Pool. It will be useful if we can delete a DB Pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3258) ability to delete db pools
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3258:
---------------------------------------
Attachment: geronimo-3258.patch
This new patch checks if the chosen db pool to be deleted is associated with the system database by checking the connection url. If it is, then nothing is done. Otherwise, it attempts to undeploy it.
Thanks,
Viet Nguyen
> ability to delete db pools
> --------------------------
>
> Key: GERONIMO-3258
> URL: https://issues.apache.org/jira/browse/GERONIMO-3258
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console, databases, usability
> Affects Versions: 2.0-M6
> Environment: windows xp
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3258.patch, geronimo-3258.patch
>
>
> Right now, there is only the option to Edit a DB Pool. It will be useful if we can delete a DB Pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3258) ability to delete db pools
Posted by "Jay D. McHugh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay D. McHugh updated GERONIMO-3258:
------------------------------------
Attachment: geronimo-3258-final.patch
Viet,
I changed your patch slightly because it would have prevented deleting any
embedded database pools (they do not have urls at all).
This version checks to see if the abstractName begins with
org.apache.geronimo.configs and uses that to determine if it is a system database or not.
Also, in the future, please use spaces instead of tabs.
Thanks for the patch!
> ability to delete db pools
> --------------------------
>
> Key: GERONIMO-3258
> URL: https://issues.apache.org/jira/browse/GERONIMO-3258
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console, databases, usability
> Affects Versions: 2.0-M6
> Environment: windows xp
> Reporter: Viet Hung Nguyen
> Assignee: Jay D. McHugh
> Attachments: geronimo-3258-final.patch, geronimo-3258.patch, geronimo-3258.patch
>
>
> Right now, there is only the option to Edit a DB Pool. It will be useful if we can delete a DB Pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3258) ability to delete db pools
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3258:
---------------------------------------
Component/s: databases
console
> ability to delete db pools
> --------------------------
>
> Key: GERONIMO-3258
> URL: https://issues.apache.org/jira/browse/GERONIMO-3258
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console, databases, usability
> Affects Versions: 2.0-M6
> Environment: windows xp
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3258.patch
>
>
> Right now, there is only the option to Edit a DB Pool. It will be useful if we can delete a DB Pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (GERONIMO-3258) ability to delete db pools
Posted by "Jay D. McHugh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay D. McHugh reassigned GERONIMO-3258:
---------------------------------------
Assignee: Jay D. McHugh
> ability to delete db pools
> --------------------------
>
> Key: GERONIMO-3258
> URL: https://issues.apache.org/jira/browse/GERONIMO-3258
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console, databases, usability
> Affects Versions: 2.0-M6
> Environment: windows xp
> Reporter: Viet Hung Nguyen
> Assignee: Jay D. McHugh
> Attachments: geronimo-3258.patch, geronimo-3258.patch
>
>
> Right now, there is only the option to Edit a DB Pool. It will be useful if we can delete a DB Pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (GERONIMO-3258) ability to delete db pools
Posted by "Viet Hung Nguyen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viet Hung Nguyen updated GERONIMO-3258:
---------------------------------------
Attachment: geronimo-3258.patch
I have added this option with this patch.
> ability to delete db pools
> --------------------------
>
> Key: GERONIMO-3258
> URL: https://issues.apache.org/jira/browse/GERONIMO-3258
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: usability
> Affects Versions: 2.0-M6
> Environment: windows xp
> Reporter: Viet Hung Nguyen
> Attachments: geronimo-3258.patch
>
>
> Right now, there is only the option to Edit a DB Pool. It will be useful if we can delete a DB Pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (GERONIMO-3258) ability to delete db pools
Posted by "Jay D. McHugh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GERONIMO-3258?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jay D. McHugh resolved GERONIMO-3258.
-------------------------------------
Resolution: Fixed
Fix Version/s: 2.0-M7
Committed revision 550963.
Thanks for the patch Viet!
> ability to delete db pools
> --------------------------
>
> Key: GERONIMO-3258
> URL: https://issues.apache.org/jira/browse/GERONIMO-3258
> Project: Geronimo
> Issue Type: Improvement
> Security Level: public(Regular issues)
> Components: console, databases, usability
> Affects Versions: 2.0-M6
> Environment: windows xp
> Reporter: Viet Hung Nguyen
> Assignee: Jay D. McHugh
> Fix For: 2.0-M7
>
> Attachments: geronimo-3258-final.patch, geronimo-3258.patch, geronimo-3258.patch
>
>
> Right now, there is only the option to Edit a DB Pool. It will be useful if we can delete a DB Pool.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.