[jira] [Commented] (NIFI-7722) Enhance error-handling during request replication

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17176466#comment-17176466 ] 

ASF subversion and git services commented on NIFI-7722:
-------------------------------------------------------

Commit 3e18d5b23603ec69e7b4ad277b79fe9620b7afb4 in nifi's branch refs/heads/main from Tamas Palfy
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=3e18d5b ]

NIFI-7722 Catching 'Throwable' instead of 'Exception' in 'NodeHttpRequest.run()' to make sure subsequent 'Object.notify()' (when request replication has completed) is not missed out even if an 'Error' is thrown.


> Enhance error-handling during request replication
> -------------------------------------------------
>
>                 Key: NIFI-7722
>                 URL: https://issues.apache.org/jira/browse/NIFI-7722
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Tamas Palfy
>            Assignee: Tamas Palfy
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In {{ThreadPoolRequestReplicator.NodeHttpRequest.run()}} the main logic is in a {{try}} block, during which all {{Exceptions}} are caught and handled properly. However we need to call an {{Object.notify()}} after that so it's crucial that the error handling covers every scenario.
> Because of this we should catch all {{Throwables}} (instead of only {{Exceptions}}), otherwise - should we encounter an {{Error}} for example - we might end up in a _deadlock_ state.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)