[jira] [Commented] (CB-10233) Support different config.xml file per CDVViewController instance

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-10233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15067812#comment-15067812 ] 

ASF GitHub Bot commented on CB-10233:
-------------------------------------

GitHub user mirkoluchi opened a pull request:

    https://github.com/apache/cordova-ios/pull/186

    CB-10233: Support different config.xml file per CDVViewController instance

    - Add a configFile property to CDVViewController (path to the config
    file, absolute or relative to main bundle)
    - Move loading of settings from -init to -viewDidLoad

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mirkoluchi/cordova-ios feature/CB-10233

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/186.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #186
    
----
commit 7069a383d35efa4e02579e6a5aee53401fe868e4
Author: Mirko Luchi <mi...@thedigitalstack.com>
Date:   2015-12-22T09:20:31Z

    CB-10233: Support different config.xml file per CDVViewController
    instance
    
    - Add a configFile property to CDVViewController (path to the config
    file, absolute or relative to main bundle)
    - Move loading of settings from -init to -viewDidLoad

----


> Support different config.xml file per CDVViewController instance
> ----------------------------------------------------------------
>
>                 Key: CB-10233
>                 URL: https://issues.apache.org/jira/browse/CB-10233
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Mirko Luchi
>            Priority: Minor
>              Labels: cordova-ios-4.1.0
>
> CDVViewController strongly assumes that cordova configuration is in a config.xml file in the application's main bundle.
> This approach has several drawbacks:
> - each instance of CDVViewController have a single shared configuration file (which is not always desireable)
> - configuration file cannot be placed in custom locations (e.g. a bundle of a library containing a reusable subclass of CDVViewController loading a custom HTML page).
> Cordova setting file path should be configurable through a property on the CDVViewController class, and settings loading should be delayed in the viewDidLoad method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org