You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@couchdb.apache.org by va...@apache.org on 2025/10/02 16:42:23 UTC

(couchdb) 01/01: Fix run_on_first_node scanner features

This is an automated email from the ASF dual-hosted git repository.

vatamane pushed a commit to branch fix-run-on-first-for-plugins
in repository https://gitbox.apache.org/repos/asf/couchdb.git

commit 86b3dc2ca8a52e4be7aa91ac6e81ad4f2e23bb6d
Author: Nick Vatamaniuc <va...@gmail.com>
AuthorDate: Thu Oct 2 12:32:17 2025 -0400

    Fix run_on_first_node scanner features
    
    `run_on_first_node` feature is a running mode for plugins which are only
    interested in design documents, and may want to avoid fetching clustered design
    docs on all nodes.
    
    However that feature didn't work since it clashed with a premature optimization
    in plugin's `scan_db/2` function, which avoided scanning the db if no shards
    were scheduled to be scanned on the first node. For example, with a 3 node
    cluster and a q=2 db, it was possible to have both of its shards scheduled to
    be scanned on db2 and db3, respectively, while the plugin was running on db1
    only. In that case the plugin would have skipped calling the main part of
    `scan_db` which does ddoc processing.
    
    The fix is to remove the premature optimization and load the ddoc even if no
    shards are scheduled to be scanned on that node since we may be dealing with a
    plugin which is only interested in design documents.
---
 src/couch_scanner/src/couch_scanner_plugin.erl | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/couch_scanner/src/couch_scanner_plugin.erl b/src/couch_scanner/src/couch_scanner_plugin.erl
index 0454a6d59..3bda54319 100644
--- a/src/couch_scanner/src/couch_scanner_plugin.erl
+++ b/src/couch_scanner/src/couch_scanner_plugin.erl
@@ -315,9 +315,7 @@ scan_dbs_fold(#full_doc_info{} = FDI, #st{shards_db = Db} = Acc) ->
             {ok, Acc2}
     end.
 
-scan_db([], #st{} = St) ->
-    {ok, St};
-scan_db([_ | _] = Shards, #st{} = St) ->
+scan_db(Shards, #st{} = St) ->
     #st{dbname = DbName, callbacks = Cbks, pst = PSt, skip_dbs = Skip} = St,
     #{db := DbCbk} = Cbks,
     case match_skip_pat(DbName, Skip) of